From: Hans-Peter Nilsson <hans-peter.nilsson@axis.com>
To: uweigand@de.ibm.com
Cc: law@redhat.com, gcc-patches@gcc.gnu.org
Subject: Re: [RFA 1/2]: Don't ignore target_header_dir when deciding inhibit_libc
Date: Mon, 12 Oct 2015 10:58:00 -0000 [thread overview]
Message-ID: <201510121058.t9CAw040015130@ignucius.se.axis.com> (raw)
In-Reply-To: <20151012095840.63E773CDC@oc7340732750.ibm.com> (message from Ulrich Weigand on Mon, 12 Oct 2015 11:58:40 +0200)
> From: Ulrich Weigand <uweigand@de.ibm.com>
> Date: Mon, 12 Oct 2015 11:58:40 +0200
(cutting *only* because I had a comment; not an indication of
preference.)
> --or--
>
> 2b) Change target_header_dir from a single directory to a list of
> directories, and check all of these for header files. This list
> would typically include both sys-include and include.
>
> This should not change behavior for any existing user, and would
> bring the header search at configure time in line with the actual
> search order used by the compiler at run time, which will probably
> be the least surprise to users anyway ...
Agreed. Just pointing out that it would take some effort in
gcc/configure.ac.
> For 1), something like the following should probably suffice:
>
> Index: gcc/configure.ac
> ===================================================================
> --- gcc/configure.ac (revision 228530)
> +++ gcc/configure.ac (working copy)
> @@ -1993,7 +1993,7 @@ elif test "x$TARGET_SYSTEM_ROOT" != x; t
> fi
>
> if test x$host != x$target || test "x$TARGET_SYSTEM_ROOT" != x; then
> - if test "x$with_headers" != x; then
> + if test "x$with_headers" != x && test "x$with_headers" != xyes; then
> target_header_dir=$with_headers
> elif test "x$with_sysroot" = x; then
> target_header_dir="${test_exec_prefix}/${target_noncanonical}/sys-include"
>
>
> I'll probably not spend any more time right now to try to implement
> either of the 2) variants; I can live with using sys-include for now.
To be clear (to those skipping most of the thread), I'm ok with this.
Thanks.
brgds, H-P
next prev parent reply other threads:[~2015-10-12 10:58 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-04 21:40 Hans-Peter Nilsson
2014-09-12 17:50 ` Ping: " Hans-Peter Nilsson
2014-09-19 6:25 ` Jeff Law
2014-09-23 21:21 ` Thomas Schwinge
2014-09-23 22:30 ` Hans-Peter Nilsson
2015-10-06 14:04 ` Ulrich Weigand
2015-10-06 14:44 ` Hans-Peter Nilsson
2015-10-06 15:25 ` Ulrich Weigand
2015-10-06 16:31 ` Hans-Peter Nilsson
2015-10-06 16:56 ` Ulrich Weigand
2015-10-06 17:28 ` Hans-Peter Nilsson
2015-10-07 15:32 ` Ulrich Weigand
2015-10-07 17:18 ` Hans-Peter Nilsson
2015-10-08 16:52 ` Ulrich Weigand
2015-10-09 2:34 ` Hans-Peter Nilsson
2015-10-12 9:58 ` Ulrich Weigand
2015-10-12 10:58 ` Hans-Peter Nilsson [this message]
2015-10-23 11:54 ` Bernd Schmidt
2016-03-17 16:35 ` Andre Vieira (lists)
2016-03-30 16:14 ` [arm-embedded]: " Andre Vieira (lists)
2016-04-07 9:31 ` [RFA 1/2]: " Andre Vieira (lists)
2016-05-25 19:37 ` Andre Vieira (lists)
2016-05-27 16:31 ` Ulrich Weigand
2016-09-09 15:04 ` [GCC-6][RFA " Andre Vieira (lists)
2016-10-17 16:05 ` Andre Vieira (lists)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201510121058.t9CAw040015130@ignucius.se.axis.com \
--to=hans-peter.nilsson@axis.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=law@redhat.com \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).