From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17222 invoked by alias); 13 Oct 2015 13:08:05 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 17191 invoked by uid 89); 13 Oct 2015 13:08:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: cam-smtp0.cambridge.arm.com Received: from fw-tnat.cambridge.arm.com (HELO cam-smtp0.cambridge.arm.com) (217.140.96.140) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 13 Oct 2015 13:07:57 +0000 Received: from arm.com (e107456-lin.cambridge.arm.com [10.2.206.78]) by cam-smtp0.cambridge.arm.com (8.13.8/8.13.8) with ESMTP id t9DD7rGJ029718; Tue, 13 Oct 2015 14:07:53 +0100 Date: Tue, 13 Oct 2015 13:08:00 -0000 From: James Greenhalgh To: Christophe Lyon Cc: "gcc-patches@gcc.gnu.org" Subject: Re: [AArch64_be] Fix vtbl[34] and vtbx4 Message-ID: <20151013130753.GA6395@arm.com> References: <20151007150941.GA31205@arm.com> <20151008091230.GA13098@arm.com> <20151012132854.GA32787@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg01243.txt.bz2 On Tue, Oct 13, 2015 at 02:05:01PM +0100, Christophe Lyon wrote: > I commited this as r228716, and noticed later that > gcc.target/aarch64/table-intrinsics.c failed because of this patch. > > This is because that testcase scans the assembly for 'tbl v' or 'tbx > v', but since I replaced some asm statements, > the space is now a tab. > > I plan to commit this (probably obvious?): > 2015-10-13 Christophe Lyon > > * gcc/testsuite/gcc.target/aarch64/table-intrinsics.c: Fix regexp > after r228716 (Fix vtbl[34] and vtbx4). Bad luck. This is fine (and yes, obvious). Thanks, James > Index: gcc/testsuite/gcc.target/aarch64/table-intrinsics.c > =================================================================== > --- gcc/testsuite/gcc.target/aarch64/table-intrinsics.c (revision 228759) > +++ gcc/testsuite/gcc.target/aarch64/table-intrinsics.c (working copy) > @@ -435,5 +435,5 @@ > return vqtbx4q_p8 (r, tab, idx); > } > > -/* { dg-final { scan-assembler-times "tbl v" 42} } */ > -/* { dg-final { scan-assembler-times "tbx v" 30} } */ > +/* { dg-final { scan-assembler-times "tbl\[ |\t\]*v" 42} } */ > +/* { dg-final { scan-assembler-times "tbx\[ |\t\]*v" 30} } */