From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 115808 invoked by alias); 14 Oct 2015 07:31:50 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 115794 invoked by uid 89); 14 Oct 2015 07:31:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 14 Oct 2015 07:31:48 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id ABFECC0BB28C; Wed, 14 Oct 2015 07:31:47 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-116-53.ams2.redhat.com [10.36.116.53]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t9E7Vjkk017760 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 14 Oct 2015 03:31:47 -0400 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id t9E7ViXj015540; Wed, 14 Oct 2015 09:31:44 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id t9E7VhRJ015539; Wed, 14 Oct 2015 09:31:43 +0200 Date: Wed, 14 Oct 2015 07:31:00 -0000 From: Jakub Jelinek To: Maxim Ostapenko Cc: GCC Patches , Kostya Serebryany , Dmitry Vyukov , Marek Polacek , Yury Gribov , Slava Garbuzov , Vyacheslav Barinov Subject: Re: [PATCH 4/7] Libsanitizer merge from upstream r249633. Message-ID: <20151014073143.GQ478@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <561CE769.6050800@partner.samsung.com> <561CE891.5080709@partner.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <561CE891.5080709@partner.samsung.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg01313.txt.bz2 On Tue, Oct 13, 2015 at 02:18:41PM +0300, Maxim Ostapenko wrote: > This is a reapplied Jakub's patch for disabling ODR violation detection. > More details can be found here > (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63888). This is ok when all the other changes are acked. > 2015-10-12 Maxim Ostapenko > > PR bootstrap/63888 > Reapply: > 2015-02-20 Jakub Jelinek > > * asan/asan_globals.cc (RegisterGlobal): Disable detect_odr_violation > support until it is rewritten upstream. > > * c-c++-common/asan/pr63888.c: New test. > > Index: libsanitizer/asan/asan_globals.cc > =================================================================== > --- libsanitizer/asan/asan_globals.cc (revision 250059) > +++ libsanitizer/asan/asan_globals.cc (working copy) > @@ -146,7 +146,9 @@ > CHECK(AddrIsInMem(g->beg)); > CHECK(AddrIsAlignedByGranularity(g->beg)); > CHECK(AddrIsAlignedByGranularity(g->size_with_redzone)); > - if (flags()->detect_odr_violation) { > + // This "ODR violation" detection is fundamentally incompatible with > + // how GCC registers globals. Disable as useless until rewritten upstream. > + if (0 && flags()->detect_odr_violation) { > // Try detecting ODR (One Definition Rule) violation, i.e. the situation > // where two globals with the same name are defined in different modules. > if (__asan_region_is_poisoned(g->beg, g->size_with_redzone)) { Jakub