From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 71060 invoked by alias); 16 Oct 2015 05:37:27 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 70428 invoked by uid 89); 16 Oct 2015 05:37:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.6 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: paperclip.tbsaunde.org Received: from tbsaunde.org (HELO paperclip.tbsaunde.org) (66.228.47.254) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 16 Oct 2015 05:37:25 +0000 Received: from tsaunders-iceball.corp.tor1.mozilla.com (unknown [66.207.208.102]) by paperclip.tbsaunde.org (Postfix) with ESMTPSA id 9B34CC06B; Fri, 16 Oct 2015 05:37:22 +0000 (UTC) Date: Fri, 16 Oct 2015 05:37:00 -0000 From: Trevor Saunders To: Bernd Schmidt Cc: tbsaunde+gcc@tbsaunde.org, gcc-patches@gcc.gnu.org Subject: Re: [PATCH 2/6] always define SETUP_FRAME_ADDRESSES Message-ID: <20151016053714.GA9822@tsaunders-iceball.corp.tor1.mozilla.com> References: <1444523150-15236-1-git-send-email-tbsaunde+gcc@tbsaunde.org> <1444523150-15236-3-git-send-email-tbsaunde+gcc@tbsaunde.org> <561B891C.2000603@redhat.com> <20151015021354.GB4317@tsaunders-iceball.corp.tor1.mozilla.com> <561F761E.8040004@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <561F761E.8040004@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-SW-Source: 2015-10/txt/msg01533.txt.bz2 On Thu, Oct 15, 2015 at 11:47:10AM +0200, Bernd Schmidt wrote: > On 10/15/2015 04:13 AM, Trevor Saunders wrote: > >On Mon, Oct 12, 2015 at 12:19:08PM +0200, Bernd Schmidt wrote: > >>If we go to the trouble of changing this, could we convert macros to target > >>hooks instead while we're there? REVERSE_CONDITION, SETUP_FRAME_ADDRESSES > >>and FRAME_ADDR_RTX all seem to be used only in a handful of ports, and > >>INITIAL_FRAME_ADDRESS_RTX only in one. > > > >I'm definitely planning to do that, but I think this is still somewhat > >useful even if only to have one list to look at for what hooks need to > >be added. > > I'd prefer to do things right from the start, at least for easy cases such > as these. Each change we make has a chance of introducing errors, and there > is a cost for people working on patches each time the code changes under > them. And for you it'll be less work in the long run as well. Its a fair concern that changing things has risks, on the other hand breaking the change up into parts makes the parts simpler to check for correctness. At any rate I don't have any more tiny patches like this coming, so I don't know how much this discussion is getting us ;) thanks! Trev > > > Bernd