public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: Thomas Schwinge <thomas@codesourcery.com>
Cc: gcc@gcc.gnu.org, gcc-patches@gcc.gnu.org,
	Jeff Law <law@redhat.com>,
	       Bernd Schmidt <bschmidt@redhat.com>
Subject: Re: OpenACC (gomp-4_0-branch) patch review (was: Merge from gomp-4_1-branch to trunk)
Date: Fri, 16 Oct 2015 10:15:00 -0000	[thread overview]
Message-ID: <20151016101314.GJ478@tucnak.redhat.com> (raw)
In-Reply-To: <87lhb3b11q.fsf@kepler.schwinge.homeip.net>

On Fri, Oct 16, 2015 at 11:44:17AM +0200, Thomas Schwinge wrote:
> But: working on getting our changes into trunk, for example, when we make
> an effort to extract from gomp-4_0-branch self-contained, individual
> patches, but it then takes weeks to get commit approval or review
> comments, I don't see how that's going to work for the thousands of lines
> patches that we're still to submit?  I mean, GCC development stage 1 is
> going to end in just a few weeks, I suppose?

Yes, see Richi's mail from today, there are 3 weeks plus weekend left in
stage 1.  I'm sorry for the delays in patch review, and will try to arrange
an hour or two daily for OpenACC/OpenMP/HSA patch review for the remainder of
stage1 (and still work on the missing OpenMP 4.5 features or fixes during
the rest of the days).  The PTX changes Nathan can review himself, or Bernd.
And I certainly appreciate if Bernd reviews some of the OMP bits from time
to time, after all, all global reviewers can do that.

> also, allow for "somewhat non-perfect" changes to be committed, and later
> address the "warts"?  (Allowing for incremental progress, while keeping

I'd prefer not to do that though, that will just mean the bad code will stay
around forever.

In any case, if you have unreviewed OpenACC/OpenMP/libgomp patches ready to
be merged into trunk, please ping them.

	Jakub

      parent reply	other threads:[~2015-10-16 10:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-13 19:12 Merge from gomp-4_1-branch to trunk Jakub Jelinek
2015-10-14  7:34 ` Sebastian Huber
2015-10-14  8:04   ` Jakub Jelinek
2015-10-14  8:10     ` Sebastian Huber
2015-10-14  8:32     ` Sebastian Huber
2015-10-16  9:47 ` OpenACC (gomp-4_0-branch) patch review (was: Merge from gomp-4_1-branch to trunk) Thomas Schwinge
2015-10-16 10:11   ` OpenACC (gomp-4_0-branch) patch review Bernd Schmidt
2015-10-16 10:15   ` Jakub Jelinek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151016101314.GJ478@tucnak.redhat.com \
    --to=jakub@redhat.com \
    --cc=bschmidt@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gcc@gcc.gnu.org \
    --cc=law@redhat.com \
    --cc=thomas@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).