From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 80099 invoked by alias); 16 Oct 2015 10:15:27 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 80081 invoked by uid 89); 16 Oct 2015 10:15:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 16 Oct 2015 10:13:26 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 7BE4AC0B64D0; Fri, 16 Oct 2015 10:13:19 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-116-53.ams2.redhat.com [10.36.116.53]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t9GADHRp025901 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 16 Oct 2015 06:13:19 -0400 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id t9GADFJr008871; Fri, 16 Oct 2015 12:13:16 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id t9GADEh1008870; Fri, 16 Oct 2015 12:13:14 +0200 Date: Fri, 16 Oct 2015 10:15:00 -0000 From: Jakub Jelinek To: Thomas Schwinge Cc: gcc@gcc.gnu.org, gcc-patches@gcc.gnu.org, Jeff Law , Bernd Schmidt Subject: Re: OpenACC (gomp-4_0-branch) patch review (was: Merge from gomp-4_1-branch to trunk) Message-ID: <20151016101314.GJ478@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <20151013191214.GL478@tucnak.redhat.com> <87lhb3b11q.fsf@kepler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87lhb3b11q.fsf@kepler.schwinge.homeip.net> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg01554.txt.bz2 On Fri, Oct 16, 2015 at 11:44:17AM +0200, Thomas Schwinge wrote: > But: working on getting our changes into trunk, for example, when we make > an effort to extract from gomp-4_0-branch self-contained, individual > patches, but it then takes weeks to get commit approval or review > comments, I don't see how that's going to work for the thousands of lines > patches that we're still to submit? I mean, GCC development stage 1 is > going to end in just a few weeks, I suppose? Yes, see Richi's mail from today, there are 3 weeks plus weekend left in stage 1. I'm sorry for the delays in patch review, and will try to arrange an hour or two daily for OpenACC/OpenMP/HSA patch review for the remainder of stage1 (and still work on the missing OpenMP 4.5 features or fixes during the rest of the days). The PTX changes Nathan can review himself, or Bernd. And I certainly appreciate if Bernd reviews some of the OMP bits from time to time, after all, all global reviewers can do that. > also, allow for "somewhat non-perfect" changes to be committed, and later > address the "warts"? (Allowing for incremental progress, while keeping I'd prefer not to do that though, that will just mean the bad code will stay around forever. In any case, if you have unreviewed OpenACC/OpenMP/libgomp patches ready to be merged into trunk, please ping them. Jakub