From: Jakub Jelinek <jakub@redhat.com>
To: Maxim Ostapenko <m.ostapenko@partner.samsung.com>
Cc: Kostya Serebryany <kcc@google.com>,
GCC Patches <gcc-patches@gcc.gnu.org>,
Dmitry Vyukov <dvyukov@google.com>,
Marek Polacek <polacek@redhat.com>,
Yury Gribov <y.gribov@samsung.com>,
Slava Garbuzov <v.garbuzov@samsung.com>,
Vyacheslav Barinov <v.barinov@samsung.com>
Subject: Re: [PATCH v2 2/6] Libsanitizer merge from upstream r250806 (was r249633).
Date: Tue, 20 Oct 2015 12:02:00 -0000 [thread overview]
Message-ID: <20151020115643.GA478@tucnak.redhat.com> (raw)
In-Reply-To: <56262357.3000503@partner.samsung.com>
On Tue, Oct 20, 2015 at 02:19:51PM +0300, Maxim Ostapenko wrote:
> + a) Location's filename must not be NULL.
> + b) Location's filename must not be equal to "".
> + c) Location's filename must not be equal to "\1".
> + d) First two bytes of filename msut not contain '\xff' symbol. */
must
> +
> +static bool
> +ubsan_use_new_style_p (location_t loc)
> +{
> + if (loc == UNKNOWN_LOCATION)
> + return false;
> +
> + expanded_location xloc = expand_location (loc);
> + if (xloc.file == NULL || strncmp (xloc.file, "\1", 2) == 0
> + || strncmp (xloc.file, "", 1) == 0 || xloc.file[0] == '\xff'
I'd use || xloc.file == '\0' || xloc.file[0] == '\xff
instead, but not a big deal for me.
> + || xloc.file[1] == '\xff')
> + return false;
> +
> + return true;
> +}
> +
Ok with the typo fix.
Jakub
next prev parent reply other threads:[~2015-10-20 11:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-20 11:17 [PATCH v2 0/6] " Maxim Ostapenko
2015-10-20 11:20 ` [PATCH v2 1/6] " Maxim Ostapenko
2015-10-20 11:56 ` Jakub Jelinek
2015-10-20 14:14 ` Maxim Ostapenko
2015-10-20 11:22 ` [PATCH v2 2/6] " Maxim Ostapenko
2015-10-20 12:02 ` Jakub Jelinek [this message]
2015-10-20 11:25 ` [PATCH v2 0/6] " Maxim Ostapenko
2015-10-20 11:28 ` [PATCH v2 4/6] " Maxim Ostapenko
2015-10-20 11:30 ` [PATCH v2 5/6] " Maxim Ostapenko
2015-10-20 11:45 ` [PATCH v2 6/6] " Maxim Ostapenko
2015-10-20 12:06 ` Jakub Jelinek
2015-10-21 9:19 ` Yury Gribov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151020115643.GA478@tucnak.redhat.com \
--to=jakub@redhat.com \
--cc=dvyukov@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=kcc@google.com \
--cc=m.ostapenko@partner.samsung.com \
--cc=polacek@redhat.com \
--cc=v.barinov@samsung.com \
--cc=v.garbuzov@samsung.com \
--cc=y.gribov@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).