From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 40626 invoked by alias); 21 Oct 2015 08:15:00 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 40603 invoked by uid 89); 21 Oct 2015 08:14:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 21 Oct 2015 08:14:58 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 11E9FC0AF78E; Wed, 21 Oct 2015 08:14:57 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-116-53.ams2.redhat.com [10.36.116.53]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t9L8EsC9002092 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 21 Oct 2015 04:14:55 -0400 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id t9L8EqdU018937; Wed, 21 Oct 2015 10:14:53 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id t9L8Ep34018936; Wed, 21 Oct 2015 10:14:51 +0200 Date: Wed, 21 Oct 2015 08:20:00 -0000 From: Jakub Jelinek To: Alexander Monakov Cc: gcc-patches@gcc.gnu.org, Dmitry Melnik Subject: Re: [gomp4 05/14] omp-low: set 'omp target entrypoint' only on entypoints Message-ID: <20151021081451.GI478@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <1445366076-16082-1-git-send-email-amonakov@ispras.ru> <1445366076-16082-6-git-send-email-amonakov@ispras.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1445366076-16082-6-git-send-email-amonakov@ispras.ru> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg02027.txt.bz2 On Tue, Oct 20, 2015 at 09:34:27PM +0300, Alexander Monakov wrote: > (note to reviewers: I'm not sure what we're after here, on the high level; > will be happy to rework the patch in a saner manner based on feedback, or even > drop it for now) > > At the moment the attribute setting logic in omp-low.c is such that if a > function that should be present in target code does not already have 'omp > declare target' attribute, it receives 'omp target entrypoint'. That is > wasteful: clearly not all user-declared target functions will be target region > entry points in OpenMP. > > The motivating example for this change is OpenMP parallel target regions. The > 'parallel' part is outlined into its own function. We don't want that > function be an 'entrypoint' on PTX (but only as a matter of optimality rather > than correctness). > > * omp-low.c (create_omp_child_function): Set "omp target entrypoint" > or "omp declare target" attribute based on is_gimple_omp_offloaded. This is principally ok, but you want to change it for 01/14. After that I think it is ready for trunk. Jakub