From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 129403 invoked by alias); 23 Oct 2015 15:26:49 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 129392 invoked by uid 89); 23 Oct 2015 15:26:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ig0-f178.google.com Received: from mail-ig0-f178.google.com (HELO mail-ig0-f178.google.com) (209.85.213.178) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 23 Oct 2015 15:26:47 +0000 Received: by igbdj2 with SMTP id dj2so17998912igb.1 for ; Fri, 23 Oct 2015 08:26:45 -0700 (PDT) X-Received: by 10.50.32.33 with SMTP id f1mr4952828igi.33.1445614005765; Fri, 23 Oct 2015 08:26:45 -0700 (PDT) Received: from msticlxl57.ims.intel.com (jfdmzpr02-ext.jf.intel.com. [134.134.137.71]) by smtp.gmail.com with ESMTPSA id m29sm8035386iod.38.2015.10.23.08.26.44 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 Oct 2015 08:26:45 -0700 (PDT) Date: Fri, 23 Oct 2015 15:32:00 -0000 From: Ilya Enkovich To: gcc-patches@gcc.gnu.org Subject: [PATCH, PR68062] Fix uniform vector operation lowering Message-ID: <20151023152623.GD23452@msticlxl57.ims.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg02467.txt.bz2 Hi, This patch checks optab exists before using it vector vector statement lowering. It fixes compilation of test from PR68062 with -funsigned-char option added (doesn't fix original testcase). Bootstrapped for x86_64-unknown-linux-gnu. OK for trunk if no regressions? Thanks, Ilya -- gcc/ 2015-10-23 Ilya Enkovich * tree-vect-generic.c (expand_vector_operations_1): Check optab exists before use it. gcc/testsuite/ 2015-10-23 Ilya Enkovich * g++.dg/pr68062.C: New test. diff --git a/gcc/testsuite/g++.dg/pr68062.C b/gcc/testsuite/g++.dg/pr68062.C new file mode 100644 index 0000000..236a488 --- /dev/null +++ b/gcc/testsuite/g++.dg/pr68062.C @@ -0,0 +1,13 @@ +/* { dg-do compile } */ +/* { dg-options "-funsigned-char" } */ + +typedef char __attribute__ ((vector_size (4))) v4qi; +typedef unsigned char __attribute__ ((vector_size (4))) uv4qi; + +v4qi v; +void ret(char a) +{ + v4qi c={a,a,a,a}; + uv4qi d={a,a,a,a}; + v = (c!=d); +} diff --git a/gcc/tree-vect-generic.c b/gcc/tree-vect-generic.c index 2005383..9c59402 100644 --- a/gcc/tree-vect-generic.c +++ b/gcc/tree-vect-generic.c @@ -1533,7 +1533,8 @@ expand_vector_operations_1 (gimple_stmt_iterator *gsi) && TYPE_MODE (TREE_TYPE (type)) == TYPE_MODE (TREE_TYPE (srhs1))) { op = optab_for_tree_code (code, TREE_TYPE (type), optab_scalar); - if (optab_handler (op, TYPE_MODE (TREE_TYPE (type))) != CODE_FOR_nothing) + if (op != unknown_optab + && optab_handler (op, TYPE_MODE (TREE_TYPE (type))) != CODE_FOR_nothing) { tree slhs = make_ssa_name (TREE_TYPE (srhs1)); gimple *repl = gimple_build_assign (slhs, code, srhs1, srhs2);