From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 45712 invoked by alias); 26 Oct 2015 10:15:50 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 45405 invoked by uid 89); 26 Oct 2015 10:15:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-qg0-f46.google.com Received: from mail-qg0-f46.google.com (HELO mail-qg0-f46.google.com) (209.85.192.46) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 26 Oct 2015 10:15:42 +0000 Received: by qgbb65 with SMTP id b65so114667486qgb.2 for ; Mon, 26 Oct 2015 03:15:38 -0700 (PDT) X-Received: by 10.140.41.240 with SMTP id z103mr40612121qgz.7.1445854537950; Mon, 26 Oct 2015 03:15:37 -0700 (PDT) Received: from msticlxl57.ims.intel.com (jfdmzpr01-ext.jf.intel.com. [134.134.139.70]) by smtp.gmail.com with ESMTPSA id 14sm12767132qgg.39.2015.10.26.03.15.34 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Oct 2015 03:15:37 -0700 (PDT) Date: Mon, 26 Oct 2015 10:17:00 -0000 From: Ilya Enkovich To: Richard Biener Cc: Jeff Law , gcc-patches Subject: Re: [PATCH, PR68062] Fix uniform vector operation lowering Message-ID: <20151026101101.GB20857@msticlxl57.ims.intel.com> References: <20151023152623.GD23452@msticlxl57.ims.intel.com> <562AA762.2030202@redhat.com> <20151026093512.GA20857@msticlxl57.ims.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg02677.txt.bz2 On 26 Oct 10:56, Richard Biener wrote: > On Mon, Oct 26, 2015 at 10:35 AM, Ilya Enkovich wrote: > > On 26 Oct 10:09, Richard Biener wrote: > >> On Sat, Oct 24, 2015 at 12:29 AM, Ilya Enkovich wrote: > >> > 2015-10-24 0:32 GMT+03:00 Jeff Law : > >> >> On 10/23/2015 09:26 AM, Ilya Enkovich wrote: > >> >>> > >> >>> Hi, > >> >>> > >> >>> This patch checks optab exists before using it vector vector statement > >> >>> lowering. It fixes compilation of test from PR68062 with -funsigned-char > >> >>> option added (doesn't fix original testcase). Bootstrapped for > >> >>> x86_64-unknown-linux-gnu. OK for trunk if no regressions? > >> >>> > >> >>> Thanks, > >> >>> Ilya > >> >>> -- > >> >>> gcc/ > >> >>> > >> >>> 2015-10-23 Ilya Enkovich > >> >>> > >> >>> * tree-vect-generic.c (expand_vector_operations_1): Check > >> >>> optab exists before use it. > >> >>> > >> >>> gcc/testsuite/ > >> >>> > >> >>> 2015-10-23 Ilya Enkovich > >> >>> > >> >>> * g++.dg/pr68062.C: New test. > >> >> > >> >> OK. > >> >> > >> >> Just curious, what was the tree code for which we couldn't find a suitable > >> >> optab? > >> > > >> > Those are various comparison codes. > >> > >> Yeah, sorry for missing that check. Btw, I was curious to see that we miss > >> a way to query from optab_tag the "kind" (normal, conversion, etc.) so code > >> can decide what optab_handler function to call (optab_handler or > >> convert_optab_handler). So the code I added errs on the "simplistic" side > >> and hopes that matching lhs and rhs1 type always gets us a non-convert optab... > > > > So probably better fix is > > > > diff --git a/gcc/tree-vect-generic.c b/gcc/tree-vect-generic.c > > index d1fc0ba..73c5cc5 100644 > > --- a/gcc/tree-vect-generic.c > > +++ b/gcc/tree-vect-generic.c > > @@ -1533,7 +1533,8 @@ expand_vector_operations_1 (gimple_stmt_iterator *gsi) > > && TYPE_MODE (TREE_TYPE (type)) == TYPE_MODE (TREE_TYPE (srhs1))) > > { > > op = optab_for_tree_code (code, TREE_TYPE (type), optab_scalar); > > - if (optab_handler (op, TYPE_MODE (TREE_TYPE (type))) != CODE_FOR_nothing) > > + if (op >= FIRST_NORM_OPTAB && op <= LAST_NORM_OPTAB > > + && optab_handler (op, TYPE_MODE (TREE_TYPE (type))) != CODE_FOR_nothing) > > { > > tree slhs = make_ssa_name (TREE_TYPE (srhs1)); > > gimple *repl = gimple_build_assign (slhs, code, srhs1, srhs2); > > > > ? > > Ah, didn't know we have those constants - yes, that's a better fix. > After all we want > optab_handler to return sth sensible for it. I'll install it then. Here is a version rebased on trunk. Thanks, Ilya -- gcc/ 2015-10-26 Ilya Enkovich * tree-vect-generic.c (expand_vector_operations_1): Check optab type before using it. diff --git a/gcc/tree-vect-generic.c b/gcc/tree-vect-generic.c index 9c59402..a376ca2 100644 --- a/gcc/tree-vect-generic.c +++ b/gcc/tree-vect-generic.c @@ -1533,7 +1533,7 @@ expand_vector_operations_1 (gimple_stmt_iterator *gsi) && TYPE_MODE (TREE_TYPE (type)) == TYPE_MODE (TREE_TYPE (srhs1))) { op = optab_for_tree_code (code, TREE_TYPE (type), optab_scalar); - if (op != unknown_optab + if (op >= FIRST_NORM_OPTAB && op <= LAST_NORM_OPTAB && optab_handler (op, TYPE_MODE (TREE_TYPE (type))) != CODE_FOR_nothing) { tree slhs = make_ssa_name (TREE_TYPE (srhs1));