From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 103205 invoked by alias); 27 Oct 2015 02:47:13 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 103187 invoked by uid 89); 27 Oct 2015 02:47:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.6 required=5.0 tests=AWL,BAYES_50,KAM_LAZY_DOMAIN_SECURITY,RDNS_DYNAMIC,TVD_RCVD_IP autolearn=no version=3.3.2 X-HELO: brightrain.aerifal.cx Received: from 216-12-86-13.cv.mvl.ntelos.net (HELO brightrain.aerifal.cx) (216.12.86.13) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 27 Oct 2015 02:47:10 +0000 Received: from dalias by brightrain.aerifal.cx with local (Exim 3.15 #2) id 1ZquHy-0000Ti-00; Tue, 27 Oct 2015 02:47:06 +0000 Date: Tue, 27 Oct 2015 03:35:00 -0000 From: Rich Felker To: Oleg Endo Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH v4] SH FDPIC backend support Message-ID: <20151027024706.GU8645@brightrain.aerifal.cx> References: <20151021034138.GA4087@brightrain.aerifal.cx> <1445433471.5521.100.camel@t-online.de> <20151021201510.GV8645@brightrain.aerifal.cx> <20151023063221.GI8645@brightrain.aerifal.cx> <1445783331.8060.3.camel@t-online.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1445783331.8060.3.camel@t-online.de> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg02832.txt.bz2 On Sun, Oct 25, 2015 at 11:28:51PM +0900, Oleg Endo wrote: > On Fri, 2015-10-23 at 02:32 -0400, Rich Felker wrote: > > Here's my updated version of the FDPIC patch with all requested > > changes made and Changelog added. I've included all the original > > authors. This is my first time writing such an extensive Changelog > > entry so please let me know if there are things I got wrong. > > I took the liberty and fixed some minor formatting trivia and extracted > functions sh_emit_storesi and sh_emit_storehi which are used in > sh_trampoline_init to effectively memcpy code into the trampoline > area. Can you please check it? If it's OK I'll commit the attached > patch to trunk. Is there anything in particular you'd like me to check? It builds fine for fdpic target, successfully compiles musl libc.so, and busybox runs with the resulting libc.so. I did a quick visual inspection of the diff between my version and yours too and didn't see anything that looked suspicious to me. Rich