public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: James Greenhalgh <james.greenhalgh@arm.com>
To: Andrew Pinski <pinskia@gmail.com>
Cc: Evandro Menezes <e.menezes@samsung.com>,
	       GCC Patches <gcc-patches@gcc.gnu.org>,
	       Marcus Shawcroft <Marcus.Shawcroft@arm.com>,
	       Kyrill Tkachov <kyrylo.tkachov@arm.com>
Subject: Re: [PATCH] [AArch64] Distinct costs for sign and zero extension
Date: Tue, 27 Oct 2015 12:02:00 -0000	[thread overview]
Message-ID: <20151027120047.GA10854@arm.com> (raw)
In-Reply-To: <CA+=Sn1naWB05gbpUPjGXtSffbXMeyDR0uS8fJaR=mK6GJT9LVQ@mail.gmail.com>

On Tue, Oct 20, 2015 at 07:52:45AM +0800, Andrew Pinski wrote:
> On Tue, Oct 20, 2015 at 7:10 AM, Evandro Menezes <e.menezes@samsung.com> wrote:
> > Some micro-architectures may favor one of sign or zero extension over the
> > other in the base plus extended register offset addressing mode.
> 
> Yes I was going to create the same patch as ThunderX is one of those
> micro-architectures.

OK (Though the patch would have looked better had all the in-tree examples
not be no-op splits!).

I've committed this as r229431 on your behalf. Please provide full ChangeLog
entries with the patch submission, I derived the Name/Email fields and
committed this:

2015-10-27  Evandro Menezes  <e.menezes@samsung.com>

	* config/aarch64/aarch64-protos.h (cpu_addrcost_table): Split member
	for register extension into sign and zero register extension.
	* config/aarch64/aarch64.c (generic_addrcost_table): Infer values
	for sign and zero register extension.
	(cortexa57_addrcost_table): Likewise.
	(xgene1_addrcost_table): Likewise.

Thanks,
James

> >
> > This patch separates the member "register_extend" of the structure
> > "cpu_addrcost_table" into two, one for sign and the other zero extension.
> >
> > Please, commit if it's alright.
> >
> > Thank you,
> >
> > --
> > Evandro Menezes
> >
> 

      reply	other threads:[~2015-10-27 12:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-19 23:40 Evandro Menezes
2015-10-19 23:59 ` Andrew Pinski
2015-10-27 12:02   ` James Greenhalgh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151027120047.GA10854@arm.com \
    --to=james.greenhalgh@arm.com \
    --cc=Marcus.Shawcroft@arm.com \
    --cc=e.menezes@samsung.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=kyrylo.tkachov@arm.com \
    --cc=pinskia@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).