From: Trevor Saunders <tbsaunde@tbsaunde.org>
To: Jeff Law <law@redhat.com>
Cc: tbsaunde+gcc@tbsaunde.org, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] remove unused config/arm/coff.h
Date: Tue, 03 Nov 2015 15:38:00 -0000 [thread overview]
Message-ID: <20151103153758.GA4927@tsaunders-iceball.corp.tor1.mozilla.com> (raw)
In-Reply-To: <5638BB60.9020308@redhat.com>
On Tue, Nov 03, 2015 at 06:49:20AM -0700, Jeff Law wrote:
> On 11/03/2015 04:31 AM, tbsaunde+gcc@tbsaunde.org wrote:
> >From: Trevor Saunders <tbsaunde+gcc@tbsaunde.org>
> >
> >Hi,
> >
> >$subject, nothing refers to this header so we might as well remove it.
> >
> >tested I can still build on x86_64-linux-gnu, not that I would expect anything
> >else or that it is particularly relevent, ok?
> >
> >Trev
> >
> >gcc/ChangeLog:
> >
> >2015-11-03 Trevor Saunders <tbsaunde+gcc@tbsaunde.org>
> >
> > * config/arm/coff.h: Remove.
> More generally, if we have a header file that's not used, I'd consider
> removing it to be obvious-enough to commit without approval.
>
> We could/should probably do the same with unused functions, with the only
> wrinkle being things that are useful for debugging but which are otherwise
> unused should be kept around.
I'd agree removing things that are dead is obvious, but sometimes things
are so convoluted its hard to be sure they are in fact dead, and then
its nice to have some confirmation you didn't miss something :)
Trev
>
> jeff
>
next prev parent reply other threads:[~2015-11-03 15:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-03 11:31 tbsaunde+gcc
2015-11-03 13:42 ` Richard Earnshaw
2015-11-03 13:49 ` Jeff Law
2015-11-03 14:17 ` Richard Earnshaw
2015-11-03 15:38 ` Trevor Saunders [this message]
2015-11-03 16:47 ` Richard Earnshaw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151103153758.GA4927@tsaunders-iceball.corp.tor1.mozilla.com \
--to=tbsaunde@tbsaunde.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=law@redhat.com \
--cc=tbsaunde+gcc@tbsaunde.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).