From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 118950 invoked by alias); 3 Nov 2015 15:38:52 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 118755 invoked by uid 89); 3 Nov 2015 15:38:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 03 Nov 2015 15:38:50 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 6E791AA0CF; Tue, 3 Nov 2015 15:38:48 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-116-136.ams2.redhat.com [10.36.116.136]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tA3FckdV010344 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 3 Nov 2015 10:38:48 -0500 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id tA3Fcj3n011721; Tue, 3 Nov 2015 16:38:46 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id tA3Fci7m011720; Tue, 3 Nov 2015 16:38:44 +0100 Date: Tue, 03 Nov 2015 15:38:00 -0000 From: Jakub Jelinek To: Nathan Sidwell Cc: GCC Patches Subject: Re: [2/2] OpenACC routine support Message-ID: <20151103153844.GR478@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <5637B1CF.5060408@acm.org> <5637B827.1020909@acm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5637B827.1020909@acm.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2015-11/txt/msg00231.txt.bz2 On Mon, Nov 02, 2015 at 02:23:19PM -0500, Nathan Sidwell wrote: > Here are the tests for the routine support. The compiler tests check > invalid combinations of gang, worker, vector & seq. The libgomp execution > tests check the expected partioning occurs within loops. As with the > reduction tests, these ones are taken from the execution model loop tests. I find the testsuite coverage insufficient, e.g. you don't have equivalent of first half of declare-simd-2.C or declare-simd-2.c (everything above #pragma omp declare simd inbranch notinbranch), to verify that if acc routine is used without the (fnname) in it, then it can't be followed by var definition and various other tokens. Jakub