From: Jakub Jelinek <jakub@redhat.com>
To: Nathan Sidwell <nathan@acm.org>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Cesar Philippidis <cesar_philippidis@mentor.com>
Subject: Re: [1/3] OpenACC reductions
Date: Wed, 04 Nov 2015 14:08:00 -0000 [thread overview]
Message-ID: <20151104140841.GF478@tucnak.redhat.com> (raw)
In-Reply-To: <563A0F02.9030907@acm.org>
On Wed, Nov 04, 2015 at 08:58:26AM -0500, Nathan Sidwell wrote:
> On 11/04/15 05:31, Jakub Jelinek wrote:
> >On Tue, Nov 03, 2015 at 11:01:57AM -0500, Nathan Sidwell wrote:
> >>On 11/03/15 10:46, Jakub Jelinek wrote:
> >>>On Mon, Nov 02, 2015 at 11:18:37AM -0500, Nathan Sidwell wrote:
> >>>>This is the core execution bits of OpenACC reductions.
> >>>>
> >>>>We have a new internal fn 'IFN_GOACC_REDUCTION' and a new target hook
> >>>>goacc.reduction, to lower it on the target compiler.
> >>>
> >>>So, let me start with a few questions:
> >>>1) does OpenACC allow UDRs or only the built-in reductions? If it
> >>> does not allow UDRs, do you have it covered by testcases that you
> >>> disallow parsing of them (e.g. when you have
> >>
> >>no UDR reductions. Will check test cases for that.
> >
> >BTW, what about min/max reductions for C/C++? Those were added in OpenMP
> >3.1, so perhaps OpenACC copied them.
>
> OpenACC has min/max, and this is exercised on gomp4. we'll get to porting
> more testcases after this rush is done, ok? (Or is there something specific
> about min/max?)
No, just wanted to know what you need to disable in the reduction clause
parsing...
For e.g. C it might be enough to add
if (!openacc)
{
and } around:
reduc_id = c_parser_peek_token (parser)->value;
break;
Jakub
next prev parent reply other threads:[~2015-11-04 14:08 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-02 16:10 [0/3] " Nathan Sidwell
2015-10-18 23:20 ` [gomp4] fortran testcase Nathan Sidwell
2015-11-02 16:18 ` [1/3] OpenACC reductions Nathan Sidwell
2015-11-03 15:46 ` Jakub Jelinek
2015-11-03 16:02 ` Nathan Sidwell
2015-11-04 10:31 ` Jakub Jelinek
2015-11-04 13:58 ` Nathan Sidwell
2015-11-04 14:08 ` Jakub Jelinek [this message]
2015-11-04 9:59 ` Jakub Jelinek
2015-11-06 10:47 ` [gomp4] " Thomas Schwinge
2016-01-07 3:55 ` [gomp4] private reductions Cesar Philippidis
2016-01-07 16:53 ` Cesar Philippidis
2016-01-09 1:14 ` Cesar Philippidis
2016-01-11 12:10 ` Thomas Schwinge
2016-01-11 14:55 ` Cesar Philippidis
2021-08-09 11:37 ` [1/3] OpenACC reductions Thomas Schwinge
2015-11-02 16:35 ` [2/3] " Nathan Sidwell
2015-11-04 10:01 ` Jakub Jelinek
2015-11-04 13:57 ` Nathan Sidwell
2015-11-04 13:27 ` Bernd Schmidt
2015-11-04 14:09 ` Nathan Sidwell
2015-11-04 16:59 ` Nathan Sidwell
2015-11-06 10:48 ` [gomp4] " Thomas Schwinge
2015-11-02 16:38 ` [3/3] " Nathan Sidwell
2015-11-04 10:03 ` Jakub Jelinek
2015-11-06 10:49 ` [gomp4] " Thomas Schwinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151104140841.GF478@tucnak.redhat.com \
--to=jakub@redhat.com \
--cc=cesar_philippidis@mentor.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=nathan@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).