From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 56245 invoked by alias); 4 Nov 2015 14:08:50 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 56223 invoked by uid 89); 4 Nov 2015 14:08:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 04 Nov 2015 14:08:48 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 8EEC8C0D61CF; Wed, 4 Nov 2015 14:08:46 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-116-136.ams2.redhat.com [10.36.116.136]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tA4E8i4o014958 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 4 Nov 2015 09:08:45 -0500 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id tA4E8hww028708; Wed, 4 Nov 2015 15:08:43 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id tA4E8fPK028707; Wed, 4 Nov 2015 15:08:41 +0100 Date: Wed, 04 Nov 2015 14:08:00 -0000 From: Jakub Jelinek To: Nathan Sidwell Cc: GCC Patches , Cesar Philippidis Subject: Re: [1/3] OpenACC reductions Message-ID: <20151104140841.GF478@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <56378AE9.2020905@acm.org> <56378CDD.3060804@acm.org> <20151103154631.GS478@tucnak.redhat.com> <5638DA75.8010900@acm.org> <20151104103150.GD478@tucnak.redhat.com> <563A0F02.9030907@acm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <563A0F02.9030907@acm.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2015-11/txt/msg00348.txt.bz2 On Wed, Nov 04, 2015 at 08:58:26AM -0500, Nathan Sidwell wrote: > On 11/04/15 05:31, Jakub Jelinek wrote: > >On Tue, Nov 03, 2015 at 11:01:57AM -0500, Nathan Sidwell wrote: > >>On 11/03/15 10:46, Jakub Jelinek wrote: > >>>On Mon, Nov 02, 2015 at 11:18:37AM -0500, Nathan Sidwell wrote: > >>>>This is the core execution bits of OpenACC reductions. > >>>> > >>>>We have a new internal fn 'IFN_GOACC_REDUCTION' and a new target hook > >>>>goacc.reduction, to lower it on the target compiler. > >>> > >>>So, let me start with a few questions: > >>>1) does OpenACC allow UDRs or only the built-in reductions? If it > >>> does not allow UDRs, do you have it covered by testcases that you > >>> disallow parsing of them (e.g. when you have > >> > >>no UDR reductions. Will check test cases for that. > > > >BTW, what about min/max reductions for C/C++? Those were added in OpenMP > >3.1, so perhaps OpenACC copied them. > > OpenACC has min/max, and this is exercised on gomp4. we'll get to porting > more testcases after this rush is done, ok? (Or is there something specific > about min/max?) No, just wanted to know what you need to disable in the reduction clause parsing... For e.g. C it might be enough to add if (!openacc) { and } around: reduc_id = c_parser_peek_token (parser)->value; break; Jakub