From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 76866 invoked by alias); 4 Nov 2015 17:23:02 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 76852 invoked by uid 89); 4 Nov 2015 17:23:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 04 Nov 2015 17:23:01 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 0239AC0D6366; Wed, 4 Nov 2015 17:22:59 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-116-136.ams2.redhat.com [10.36.116.136]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tA4HMw7A008830 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 4 Nov 2015 12:22:59 -0500 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id tA4HMvEc027302; Wed, 4 Nov 2015 18:22:57 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id tA4HMuxC027301; Wed, 4 Nov 2015 18:22:56 +0100 Date: Wed, 04 Nov 2015 17:23:00 -0000 From: Jakub Jelinek To: Thomas Schwinge Cc: Cesar Philippidis , "gcc-patches@gcc.gnu.org" Subject: Re: [openacc] acc loop updates in fortran Message-ID: <20151104172256.GO478@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <5639764A.2000209@codesourcery.com> <20151104103028.GC478@tucnak.redhat.com> <87si4lznp5.fsf@kepler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87si4lznp5.fsf@kepler.schwinge.homeip.net> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2015-11/txt/msg00381.txt.bz2 On Wed, Nov 04, 2015 at 06:20:06PM +0100, Thomas Schwinge wrote: > Hi Jakub! > > On Wed, 4 Nov 2015 11:30:28 +0100, Jakub Jelinek wrote: > > > gfc_match_oacc_update (void) > > > { > > > gfc_omp_clauses *c; > > > + locus here = gfc_current_locus; > > > + > > > if (gfc_match_omp_clauses (&c, OACC_UPDATE_CLAUSES, false, false, true) > > > != MATCH_YES) > > > return MATCH_ERROR; > > > > > > + if (!c->lists[OMP_LIST_MAP]) > > > + { > > > + gfc_error ("% must contain at least one " > > > + "% or % clause at %L", &here); > > > > There is no host/self clause I'd guess, so you should spell those > > separately. > > That's the same language as used in the C and C++ front ends; the host > and self clauses are synonymous. Then it should be %/% at least, or better % or %. Both in Fortran and in the C/C++ FEs. Jakub