From: Jakub Jelinek <jakub@redhat.com>
To: "Dominique d'Humières" <dominiq@lps.ens.fr>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] PR68271 [6 Regression] Boostrap fails on x86_64-apple-darwin14 at r230084
Date: Wed, 11 Nov 2015 13:14:00 -0000 [thread overview]
Message-ID: <20151111131441.GG5675@tucnak.redhat.com> (raw)
In-Reply-To: <9219A6A9-0D23-47B1-99DF-892D310754EF@lps.ens.fr>
On Wed, Nov 11, 2015 at 02:11:38PM +0100, Dominique d'Humières wrote:
> The following patch restore bootstrap on darwin
>
> --- ../_clean/gcc/cp/parser.h 2015-11-10 01:54:44.000000000 +0100
> +++ gcc/cp/parser.h 2015-11-11 12:10:28.000000000 +0100
> @@ -48,7 +48,7 @@ struct GTY (()) cp_token {
> /* Token flags. */
> unsigned char flags;
> /* Identifier for the pragma. */
> - ENUM_BITFIELD (pragma_kind) pragma_kind : 6;
> + ENUM_BITFIELD (pragma_kind) pragma_kind : 8;
> /* True if this token is from a context where it is implicitly extern "C" */
> BOOL_BITFIELD implicit_extern_c : 1;
> /* True if an error has already been reported for this token, such as a
> --- ../_clean/gcc/c-family/c-pragma.c 2015-11-10 01:54:43.000000000 +0100
> +++ gcc/c-family/c-pragma.c 2015-11-11 12:10:25.000000000 +0100
> @@ -1372,7 +1372,7 @@ c_register_pragma_1 (const char *space,
>
> /* The C++ front end allocates 6 bits in cp_token; the C front end
> allocates 7 bits in c_token. At present this is sufficient. */
> - gcc_assert (id < 64);
> + gcc_assert (id < 256);
> }
>
> cpp_register_deferred_pragma (parse_in, space, name, id,
>
> OK to commit?
As written in the PR, please add a ChangeLog entry, don't forget about
PR bootstrap/68271
line, and please update the 6 and 7 numbers in the comment to 8.
With that the patch is ok.
As a follow-up, we'll remove pragma_kind field in the C++ FE, to shrink the
token by 64 bits.
Jakub
next prev parent reply other threads:[~2015-11-11 13:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-11 13:11 Dominique d'Humières
2015-11-11 13:14 ` Jakub Jelinek [this message]
2015-11-11 14:10 ` Dominique d'Humières
2015-11-11 14:19 ` Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151111131441.GG5675@tucnak.redhat.com \
--to=jakub@redhat.com \
--cc=dominiq@lps.ens.fr \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).