public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jonathan Wakely <jwakely@redhat.com>
To: Ville Voutilainen <ville.voutilainen@gmail.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
	       libstdc++ <libstdc++@gcc.gnu.org>
Subject: Re: [v3 PATCH] Implement D0013R2, logical type traits.
Date: Wed, 11 Nov 2015 22:18:00 -0000	[thread overview]
Message-ID: <20151111221800.GU2937@redhat.com> (raw)
In-Reply-To: <CAFk2RUZn0w2JCd4wCpzrCY4GFf=i1mzCdaTQgpAvGiKyakntJw@mail.gmail.com>

On 12/11/15 00:06 +0200, Ville Voutilainen wrote:
>--- a/gcc/testsuite/g++.dg/cpp0x/Wattributes1.C
>+++ b/gcc/testsuite/g++.dg/cpp0x/Wattributes1.C
>@@ -5,4 +5,4 @@
> #include <new>
> __attribute__((visibility("hidden")))void*operator new(std::size_t); // { dg-warning "visibility attribute ignored" }
>
>-// { dg-message "previous declaration" "" { target *-*-* } 111 }
>+// { dg-message "previous declaration" "" { target *-*-* } 116 }
>diff --git a/libstdc++-v3/include/experimental/type_traits b/libstdc++-v3/include/experimental/type_traits
>index b0ed3b0..b7f3bda 100644
>--- a/libstdc++-v3/include/experimental/type_traits
>+++ b/libstdc++-v3/include/experimental/type_traits
>@@ -271,6 +271,28 @@ template<typename _To, template<typename...> class _Op, typename... _Args>
>   constexpr bool is_detected_convertible_v
>     = is_detected_convertible<_To, _Op, _Args...>::value;
>
>+#if __cplusplus > 201402L
>+
>+#define __cpp_lib_experimental_logical_traits 201511
>+
>+using std::conjunction;
>+using std::disjunction;
>+using std::negation;

It's unfortunate if the std::experimental versions are only available
for C++17 mode, because the whole point of putting it into both C++17
and the TS was that users can make us of the std::experimental
versions sooner than they can make use of C++17 version. If both
versions depend on using -std=c++17 then the TS versions are entirely
redundant.

So I think we want to define them again, independently, in
<experimental/type_traits>, even though it might lead to ambiguities
for code that does:

using namespace std;
using namespace std::experimental;

  reply	other threads:[~2015-11-11 22:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-11 22:06 Ville Voutilainen
2015-11-11 22:18 ` Jonathan Wakely [this message]
2015-11-11 22:46   ` Ville Voutilainen
2015-11-12 13:41     ` Jonathan Wakely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151111221800.GU2937@redhat.com \
    --to=jwakely@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=libstdc++@gcc.gnu.org \
    --cc=ville.voutilainen@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).