From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 72034 invoked by alias); 12 Nov 2015 08:53:10 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 72019 invoked by uid 89); 12 Nov 2015 08:53:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL,BAYES_20,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 12 Nov 2015 08:53:09 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id E7E6DCF90; Thu, 12 Nov 2015 08:53:07 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-116-34.ams2.redhat.com [10.36.116.34]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tAC8r5n6020594 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 12 Nov 2015 03:53:07 -0500 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id tAC8r4vc002352; Thu, 12 Nov 2015 09:53:04 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id tAC8r2AD002351; Thu, 12 Nov 2015 09:53:02 +0100 Date: Thu, 12 Nov 2015 08:53:00 -0000 From: Jakub Jelinek To: Nathan Sidwell Cc: GCC Patches , Cesar Philippidis Subject: Re: open acc default data attribute Message-ID: <20151112085301.GW5675@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <564378BB.8050400@acm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <564378BB.8050400@acm.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2015-11/txt/msg01454.txt.bz2 On Wed, Nov 11, 2015 at 12:19:55PM -0500, Nathan Sidwell wrote: > this patch implements default data attribute determination. The current > behaviour defaults to 'copy' and ignores 'default(none)'. The patch > corrects that. > > 1) We emit a diagnostic when 'default(none)' is in effect. The fortran FE > emits some artificial decls that it doesn't otherwise annotate, which is why > we check DECL_ARTIFICIAL. IIUC Cesar had a patch to address that but it > needed some reworking? I don't think treating DECL_ARTIFICIAL specially is a bug of any kind, there are tons of different artificals even for C/C++ VLAs etc., and user has no way to put them into any clauses explicitly, so what we do with them is GCC internal thing. > 2015-11-11 Nathan Sidwell > > gcc/ > * gimplify.c (oacc_default_clause): New. > (omp_notice_variable): Call it. > > gcc/testsuite/ > * c-c++-common/goacc/data-default-1.c: New. > > libgomp/ > * testsuite/libgomp.oacc-c-c++-common/default-1.c: New. + error ("%qE not specified in enclosing OpenACC %s construct", + DECL_NAME (lang_hooks.decls.omp_report_decl (decl)), rkind); + error_at (ctx->location, "enclosing OpenACC %s construct", rkind); I'd use %qs instead of %s. Otherwise ok. Jakub