[PATCH, PR68286] Fix vector comparison expand

[PATCH, PR68286] Fix vector comparison expand

[Ilya Enkovich]

Hi,

My vector comparison patches broken expand of vector comparison on targets which don't have new comparison patterns but support VEC_COND_EXPR.  This happens because it's not checked vector comparison may be expanded as a comparison.  This patch fixes it.  Bootstrapped and regtested on powerpc64le-unknown-linux-gnu.  OK for trunk?

Thanks,
Ilya
--
gcc/

2015-11-12  Ilya Enkovich  <enkovich.gnu@gmail.com>

	* expr.c (do_store_flag): Expand vector comparison as
	VEC_COND_EXPR if vector comparison is not supported
	by target.

gcc/testsuite/

2015-11-12  Ilya Enkovich  <enkovich.gnu@gmail.com>

	* gcc.dg/pr68286.c: New test.


diff --git a/gcc/expr.c b/gcc/expr.c
index 03936ee..bd43dc4 100644
--- a/gcc/expr.c
+++ b/gcc/expr.c
@@ -11128,7 +11128,8 @@ do_store_flag (sepops ops, rtx target, machine_mode mode)
   if (TREE_CODE (ops->type) == VECTOR_TYPE)
     {
       tree ifexp = build2 (ops->code, ops->type, arg0, arg1);
-      if (VECTOR_BOOLEAN_TYPE_P (ops->type))
+      if (VECTOR_BOOLEAN_TYPE_P (ops->type)
+	  && expand_vec_cmp_expr_p (TREE_TYPE (arg0), ops->type))
 	return expand_vec_cmp_expr (ops->type, ifexp, target);
       else
 	{
diff --git a/gcc/testsuite/gcc.dg/pr68286.c b/gcc/testsuite/gcc.dg/pr68286.c
new file mode 100644
index 0000000..d0392e8
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/pr68286.c
@@ -0,0 +1,17 @@
+/* PR target/68286 */
+/* { dg-do compile } */
+/* { dg-options "-O3" } */
+
+int a, b, c;
+int fn1 ()
+{
+  int d[] = {0};
+  for (; c; c++)
+    {
+      float e = c;
+      if (e)
+        d[0]++;
+    }
+  b = d[0];
+  return a;
+}

Re: [PATCH, PR68286] Fix vector comparison expand

[Richard Biener]

On Thu, Nov 12, 2015 at 10:57 AM, Ilya Enkovich <enkovich.gnu@gmail.com> wrote:
> Hi,
>
> My vector comparison patches broken expand of vector comparison on targets which don't have new comparison patterns but support VEC_COND_EXPR.  This happens because it's not checked vector comparison may be expanded as a comparison.  This patch fixes it.  Bootstrapped and regtested on powerpc64le-unknown-linux-gnu.  OK for trunk?

Ok.

Thanks,
Richard.

> Thanks,
> Ilya
> --
> gcc/
>
> 2015-11-12  Ilya Enkovich  <enkovich.gnu@gmail.com>
>
>         * expr.c (do_store_flag): Expand vector comparison as
>         VEC_COND_EXPR if vector comparison is not supported
>         by target.
>
> gcc/testsuite/
>
> 2015-11-12  Ilya Enkovich  <enkovich.gnu@gmail.com>
>
>         * gcc.dg/pr68286.c: New test.
>
>
> diff --git a/gcc/expr.c b/gcc/expr.c
> index 03936ee..bd43dc4 100644
> --- a/gcc/expr.c
> +++ b/gcc/expr.c
> @@ -11128,7 +11128,8 @@ do_store_flag (sepops ops, rtx target, machine_mode mode)
>    if (TREE_CODE (ops->type) == VECTOR_TYPE)
>      {
>        tree ifexp = build2 (ops->code, ops->type, arg0, arg1);
> -      if (VECTOR_BOOLEAN_TYPE_P (ops->type))
> +      if (VECTOR_BOOLEAN_TYPE_P (ops->type)
> +         && expand_vec_cmp_expr_p (TREE_TYPE (arg0), ops->type))
>         return expand_vec_cmp_expr (ops->type, ifexp, target);
>        else
>         {
> diff --git a/gcc/testsuite/gcc.dg/pr68286.c b/gcc/testsuite/gcc.dg/pr68286.c
> new file mode 100644
> index 0000000..d0392e8
> --- /dev/null
> +++ b/gcc/testsuite/gcc.dg/pr68286.c
> @@ -0,0 +1,17 @@
> +/* PR target/68286 */
> +/* { dg-do compile } */
> +/* { dg-options "-O3" } */
> +
> +int a, b, c;
> +int fn1 ()
> +{
> +  int d[] = {0};
> +  for (; c; c++)
> +    {
> +      float e = c;
> +      if (e)
> +        d[0]++;
> +    }
> +  b = d[0];
> +  return a;
> +}