From: Jonathan Wakely <jwakely@redhat.com>
To: Gerald Pfeifer <gerald@pfeifer.com>
Cc: "Dominique d'Humières" <dominiq@lps.ens.fr>,
ville.voutilainen@gmail.com,
gcc-patches <gcc-patches@gcc.gnu.org>,
libstdc++@gcc.gnu.org
Subject: Re: [v3 PATCH] LWG 2510, make the default constructors of library tag types explicit.
Date: Thu, 12 Nov 2015 16:13:00 -0000 [thread overview]
Message-ID: <20151112161304.GE2937@redhat.com> (raw)
In-Reply-To: <20151112143608.GC2937@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1168 bytes --]
On 12/11/15 14:36 +0000, Jonathan Wakely wrote:
>On 12/11/15 15:23 +0100, Gerald Pfeifer wrote:
>>On Wed, 11 Nov 2015, Jonathan Wakely wrote:
>>>Fixed by this patch.
>>
>>Thanks, Jonathan! Unfortunately bootstrap is still broken
>>(on i386-unknown-freebsd11.0 at least):
>
>Different issue.
>
>>In file included from
>>/scratch/tmp/gerald/gcc-HEAD/libstdc++-v3/src/c++11/thread.cc:27:0:
>>/scratch/tmp/gerald/OBJ-1112-1414/i386-unknown-freebsd10.2/libstdc++-v3/include/
>>thread: In function âvoid std::this_thread::sleep_for(const std::chrono::duration<_Rep1, _Period1>&)â:
>>/scratch/tmp/gerald/OBJ-1112-1414/i386-unknown-freebsd10.2/libstdc++-v3/include/
>>thread:300:44: error: âerrnoâ was not declared in this scope
>>while (::nanosleep(&__ts, &__ts) == -1 && errno == EINTR)
>> ^
>>/scratch/tmp/gerald/OBJ-1112-1414/i386-unknown-freebsd10.2/libstdc++-v3/include/
>>thread:300:53: error: âEINTRâ was not declared in this scope
>>while (::nanosleep(&__ts, &__ts) == -1 && errno == EINTR)
>
>Does adding #include <errno.h> to libstdc++-v3/include/std/thread
>solve it?
Committed to trunk.
[-- Attachment #2: patch.txt --]
[-- Type: text/x-patch, Size: 562 bytes --]
commit ede84363f2a4374b0d16ffda19fbcffdc44221c3
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Thu Nov 12 15:21:24 2015 +0000
* include/std/thread: Include <cerrno> for EINTR.
diff --git a/libstdc++-v3/include/std/thread b/libstdc++-v3/include/std/thread
index 5940e6e..8c01feb 100644
--- a/libstdc++-v3/include/std/thread
+++ b/libstdc++-v3/include/std/thread
@@ -38,6 +38,7 @@
#include <chrono>
#include <functional>
#include <memory>
+#include <cerrno>
#include <bits/functexcept.h>
#include <bits/functional_hash.h>
#include <bits/gthr.h>
next prev parent reply other threads:[~2015-11-12 16:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-11 17:18 Dominique d'Humières
2015-11-11 17:30 ` Jonathan Wakely
2015-11-12 14:23 ` Gerald Pfeifer
2015-11-12 14:27 ` Ville Voutilainen
2015-11-12 14:36 ` Jonathan Wakely
2015-11-12 16:13 ` Jonathan Wakely [this message]
2015-11-12 16:19 ` Gerald Pfeifer
-- strict thread matches above, loose matches on Subject: below --
2015-11-10 20:01 Ville Voutilainen
2015-11-11 14:17 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151112161304.GE2937@redhat.com \
--to=jwakely@redhat.com \
--cc=dominiq@lps.ens.fr \
--cc=gcc-patches@gcc.gnu.org \
--cc=gerald@pfeifer.com \
--cc=libstdc++@gcc.gnu.org \
--cc=ville.voutilainen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).