public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: James Greenhalgh <james.greenhalgh@arm.com>
To: Richard Biener <richard.guenther@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
	       Marcus Shawcroft <marcus.shawcroft@arm.com>,
	       Richard Earnshaw <richard.earnshaw@arm.com>
Subject: Re: [AArch64] Cortex-A57 Choose some new branch costs.
Date: Mon, 16 Nov 2015 09:28:00 -0000	[thread overview]
Message-ID: <20151116092819.GA9586@arm.com> (raw)
In-Reply-To: <CAFiYyc2dKZ_92rupoR4Wg-L+59F_Uqs4qmGZEnGvu=c1ggSxtg@mail.gmail.com>

On Fri, Nov 13, 2015 at 11:40:56AM +0100, Richard Biener wrote:
> On Fri, Nov 13, 2015 at 11:13 AM, James Greenhalgh
> <james.greenhalgh@arm.com> wrote:
> >
> > Hi,
> >
> > With all the work that has recently gone in to ifcvt, I thought I'd revisit
> > the branch cost settings for Cortex-A57. After a run of experiments [1],
> > I found {1, 3} to be the sweet spot, giving a small set of performance
> > improvements across some popular benchmarks.
> >
> > I'd therefore like to propose changing the branch cost to those numbers.
> >
> > Patch bootstrapped tuning for Cortex-A57 with no issues. I'll revisit
> > the same for Cortex-A53.
> >
> > OK?
> 
> Can you re-do the experiment with adding a LOGICAL_OP_NON_SHORT_CIRCUIT
> target macro for aarch64?  It's fallback uses BRANCH_COST (see fold-const.c
> and tree-ssa-ifcombine.c)

This didn't drastically change the results for the workloads I was
using as benchmarks. I'd still pick {1, 3} out as the winner.

Thanks,
James

> > ---
> > 2015-11-12  James Greenhalgh  <james.greenhalgh@arm.com>
> >
> >         * config/aarch64/aarch64.c (cortexa57_branch_costs): New.
> >         (cortexa57_tunings): Use it.
> >
> 

  reply	other threads:[~2015-11-16  9:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-13 10:13 James Greenhalgh
2015-11-13 10:41 ` Richard Biener
2015-11-16  9:28   ` James Greenhalgh [this message]
2015-11-16 10:20 ` Richard Earnshaw

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151116092819.GA9586@arm.com \
    --to=james.greenhalgh@arm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=marcus.shawcroft@arm.com \
    --cc=richard.earnshaw@arm.com \
    --cc=richard.guenther@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).