From: DJ Delorie <dj@redhat.com>
To: Michael McConville <mmcco@mykolab.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] ctype functions and signedness
Date: Tue, 17 Nov 2015 00:18:00 -0000 [thread overview]
Message-ID: <201511170018.tAH0IEAw001995@greed.delorie.com> (raw)
In-Reply-To: <20151116155919.GA13057@thinkpad.swarthmore.edu> (message from Michael McConville on Mon, 16 Nov 2015 10:59:20 -0500)
> --- libiberty/pex-win32.c
> +++ /tmp/cocci-output-25924-3a75ca-pex-win32.c
> @@ -547,8 +547,8 @@ env_compare (const void *a_ptr, const vo
>
> do
> {
> - c1 = (unsigned char) tolower (*a++);
> - c2 = (unsigned char) tolower (*b++);
> + c1 = (unsigned char) tolower ((unsigned char)*a++);
> + c2 = (unsigned char) tolower ((unsigned char)*b++);
>
> if (c1 == '=')
> c1 = '\0';
Since the only use of a and b in this function are to pass to tolower,
changing the type of a and b to unsigned char (and updating the casts
where they're initialized) would make more sense.
next prev parent reply other threads:[~2015-11-17 0:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-16 15:59 Michael McConville
2015-11-17 0:18 ` DJ Delorie [this message]
2015-11-17 0:24 ` Michael McConville
2015-11-24 23:15 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201511170018.tAH0IEAw001995@greed.delorie.com \
--to=dj@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=mmcco@mykolab.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).