public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Ilya Verbin <iverbin@gmail.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: gcc-patches@gcc.gnu.org, Kirill Yukhin <kirill.yukhin@gmail.com>,
	andrew.n.senkevich@gmail.com
Subject: Re: [gomp4.1] Handle linear clause modifiers in declare simd
Date: Wed, 18 Nov 2015 17:31:00 -0000	[thread overview]
Message-ID: <20151118173053.GB4267@msticlxl57.ims.intel.com> (raw)
In-Reply-To: <20150701105538.GT10247@tucnak.redhat.com>

Hi!

On Wed, Jul 01, 2015 at 12:55:38 +0200, Jakub Jelinek wrote:
> I've committed following patch, which per the new ABI additions
> mangles and handles the various new linear clause modifiers in
> declare simd functions.  The vectorizer side is not done yet,
>
> [...]
>
> @@ -14195,12 +14216,25 @@ simd_clone_mangle (struct cgraph_node *n
>      {
>        struct cgraph_simd_clone_arg arg = clone_info->args[n];
>  
> -      if (arg.arg_type == SIMD_CLONE_ARG_TYPE_UNIFORM)
> -	pp_character (&pp, 'u');
> -      else if (arg.arg_type == SIMD_CLONE_ARG_TYPE_LINEAR_CONSTANT_STEP)
> +      switch (arg.arg_type)
>  	{
> -	  gcc_assert (arg.linear_step != 0);
> +	case SIMD_CLONE_ARG_TYPE_UNIFORM:
> +	  pp_character (&pp, 'u');
> +	  break;
> +	case SIMD_CLONE_ARG_TYPE_LINEAR_CONSTANT_STEP:
>  	  pp_character (&pp, 'l');
> +	  goto mangle_linear;
> +	case SIMD_CLONE_ARG_TYPE_LINEAR_REF_CONSTANT_STEP:
> +	  pp_character (&pp, 'R');
> +	  goto mangle_linear;
> +	case SIMD_CLONE_ARG_TYPE_LINEAR_VAL_CONSTANT_STEP:
> +	  pp_character (&pp, 'L');
> +	  goto mangle_linear;
> +	case SIMD_CLONE_ARG_TYPE_LINEAR_UVAL_CONSTANT_STEP:
> +	  pp_character (&pp, 'U');
> +	  goto mangle_linear;
> +	mangle_linear:
> +	  gcc_assert (arg.linear_step != 0);

Could you please point to where the new ABI additions are documented?
I can't find R/L/U parameter types in [1] and [2].

[1] https://sourceware.org/glibc/wiki/libmvec?action=AttachFile&do=view&target=VectorABI.txt
[2] https://groups.google.com/forum/#!topic/x86-64-abi/LmppCfN1rZ4

Thanks,
  -- Ilya

  parent reply	other threads:[~2015-11-18 17:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-01 10:55 Jakub Jelinek
2015-07-14 11:41 ` Ilya Verbin
2015-07-14 12:48   ` Jakub Jelinek
2015-11-18 17:31 ` Ilya Verbin [this message]
2015-11-18 17:40   ` Jakub Jelinek
2015-11-18 19:28     ` Tian, Xinmin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151118173053.GB4267@msticlxl57.ims.intel.com \
    --to=iverbin@gmail.com \
    --cc=andrew.n.senkevich@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@redhat.com \
    --cc=kirill.yukhin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).