From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1445 invoked by alias); 20 Nov 2015 10:18:24 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 1426 invoked by uid 89); 20 Nov 2015 10:18:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 20 Nov 2015 10:18:22 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 6C45B65663; Fri, 20 Nov 2015 10:18:21 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-116-34.ams2.redhat.com [10.36.116.34]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tAKAIGQf001104 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 20 Nov 2015 05:18:19 -0500 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id tAKAIEPQ021507; Fri, 20 Nov 2015 11:18:15 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id tAKAIBkl021506; Fri, 20 Nov 2015 11:18:11 +0100 Date: Fri, 20 Nov 2015 10:18:00 -0000 From: Jakub Jelinek To: Cesar Philippidis Cc: "gcc-patches@gcc.gnu.org" , Fortran List , Tobias Burnus Subject: Re: update acc routines in fortran Message-ID: <20151120101811.GE5675@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <564DF845.3030308@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <564DF845.3030308@codesourcery.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2015-11/txt/msg02453.txt.bz2 On Thu, Nov 19, 2015 at 08:26:45AM -0800, Cesar Philippidis wrote: > (gfc_oacc_routine_name): New struct; Full stop instead of semicolon. > diff --git a/gcc/tree-nested.c b/gcc/tree-nested.c > index 1f6311c..e321072 100644 > --- a/gcc/tree-nested.c > +++ b/gcc/tree-nested.c > @@ -1106,6 +1106,9 @@ convert_nonlocal_omp_clauses (tree *pclauses, struct walk_stmt_info *wi) > case OMP_CLAUSE_NUM_TASKS: > case OMP_CLAUSE_HINT: > case OMP_CLAUSE__CILK_FOR_COUNT_: > + case OMP_CLAUSE_NUM_GANGS: > + case OMP_CLAUSE_NUM_WORKERS: > + case OMP_CLAUSE_VECTOR_LENGTH: > wi->val_only = true; > wi->is_lhs = false; > convert_nonlocal_reference_op (&OMP_CLAUSE_OPERAND (clause, 0), > @@ -1173,6 +1176,10 @@ convert_nonlocal_omp_clauses (tree *pclauses, struct walk_stmt_info *wi) > case OMP_CLAUSE_THREADS: > case OMP_CLAUSE_SIMD: > case OMP_CLAUSE_DEFAULTMAP: > + case OMP_CLAUSE_GANG: > + case OMP_CLAUSE_WORKER: > + case OMP_CLAUSE_VECTOR: This looks wrong. OMP_CLAUSE_GANG has 2 arguments, OMP_CLAUSE_WORKER and OMP_CLAUSE_VECTOR one argument, if you use a non-local decl or local decl that is referenced by a nested routine in those operands, it won't be handled properly. > @@ -1830,6 +1840,10 @@ convert_local_omp_clauses (tree *pclauses, struct walk_stmt_info *wi) > case OMP_CLAUSE_THREADS: > case OMP_CLAUSE_SIMD: > case OMP_CLAUSE_DEFAULTMAP: > + case OMP_CLAUSE_GANG: > + case OMP_CLAUSE_WORKER: > + case OMP_CLAUSE_VECTOR: > + case OMP_CLAUSE_SEQ: Ditto. Otherwise LGTM. Jakub