From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-415017-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 109578 invoked by alias); 23 Nov 2015 14:51:49 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 109489 invoked by uid 89); 23 Nov 2015 14:51:49 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2
X-HELO: cam-smtp0.cambridge.arm.com
Received: from fw-tnat.cambridge.arm.com (HELO cam-smtp0.cambridge.arm.com) (217.140.96.140) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 23 Nov 2015 14:51:48 +0000
Received: from arm.com (e107456-lin.cambridge.arm.com [10.2.206.78])	by cam-smtp0.cambridge.arm.com (8.13.8/8.13.8) with ESMTP id tANEpiQ2005746;	Mon, 23 Nov 2015 14:51:44 GMT
Date: Mon, 23 Nov 2015 14:55:00 -0000
From: James Greenhalgh <james.greenhalgh@arm.com>
To: Kyrill Tkachov <kyrylo.tkachov@arm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,        Marcus Shawcroft <marcus.shawcroft@arm.com>,        Richard Earnshaw <Richard.Earnshaw@arm.com>
Subject: Re: [PATCH][AArch64] PR target/68363 Check that argument is real INSN in aarch64_madd_needs_nop
Message-ID: <20151123145143.GA14088@arm.com>
References: <5649D86C.4010409@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5649D86C.4010409@arm.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-IsSubscribed: yes
X-SW-Source: 2015-11/txt/msg02733.txt.bz2

On Mon, Nov 16, 2015 at 01:21:48PM +0000, Kyrill Tkachov wrote:
> Hi all,
> 
> This RTL checking ICE occurs when processing an rtx_insn* in
> aarch64_madd_needs_nop that apparently holds JUMP_TABLE_DATA. This shouldn't
> be passed to recog. So instead reject it with the INSN_P check.  Such
> rtx_insns are not relevant to the code in aarch64_madd_needs_nop anyway.
> 
> Bootstrapped and tested on trunk, GCC 5 and 4.9 configured with
> --enable-fix-cortex-a53-835769 --enable-checking=yes,rtl.
> 
> Ok for all branches? (the testcase passes on 4.8, presumably before the
> conversion to rtx_insn)
> 
> 2015-11-16  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>
> 
>     PR target/68363
>     * config/aarch64/aarch64.c (aarch64_madd_needs_nop): Reject arguments
>     that are not INSN_P.
> 
> 2015-11-16  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>
> 
>     PR target/68363
>     * gcc.target/aarch64/pr68363_1.c: New test.


OK.

Thanks,
James