public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jan Hubicka <hubicka@ucw.cz>
To: Tom de Vries <Tom_deVries@mentor.com>
Cc: Ilya Verbin <iverbin@gmail.com>, Jan Hubicka <hubicka@ucw.cz>,
	"H.J. Lu" <hjl.tools@gmail.com>,
	Richard Biener <rguenther@suse.de>,
	GCC Patches <gcc-patches@gcc.gnu.org>,
	Andi Kleen <ak@linux.intel.com>,
	Cary Coutant <ccoutant@google.com>,
	Ian Lance Taylor <iant@google.com>,
	Kirill Yukhin <kirill.yukhin@gmail.com>
Subject: Re: [RFC] Getting LTO incremental linking work
Date: Sun, 29 Nov 2015 21:15:00 -0000	[thread overview]
Message-ID: <20151129200317.GB10284@kam.mff.cuni.cz> (raw)
In-Reply-To: <5659D60E.3080406@mentor.com>

> 
> 2015-11-28  Tom de Vries  <tom@codesourcery.com>
> 
> 	* lto-wrapper.c (run_gcc): Handle -flinker-output argument.

Thanks, this looks fine to me.  THe way options are handled in lto-wrapper
seems like a gross hack.  Hopefully we will manage to clean this up eventually.
What happens when I call one of input objects -fresolution=.o?

Honza
> 
> ---
>  gcc/lto-wrapper.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/gcc/lto-wrapper.c b/gcc/lto-wrapper.c
> index b9ac535..e4772d1 100644
> --- a/gcc/lto-wrapper.c
> +++ b/gcc/lto-wrapper.c
> @@ -1096,7 +1096,10 @@ run_gcc (unsigned argc, char *argv[])
>    if (have_offload && !have_lto)
>      {
>        for (i = 1; i < argc; ++i)
> -	if (strncmp (argv[i], "-fresolution=", sizeof ("-fresolution=") - 1))
> +	if (strncmp (argv[i], "-fresolution=",
> +		     sizeof ("-fresolution=") - 1) != 0
> +	    && strncmp (argv[i], "-flinker-output=",
> +			sizeof ("-flinker-output=") - 1) != 0)
>  	  {
>  	    char *out_file;
>  	    /* Can be ".o" or ".so".  */

  reply	other threads:[~2015-11-29 20:03 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-25  9:04 Jan Hubicka
2015-11-25 11:19 ` Richard Biener
2015-11-25 15:45   ` H.J. Lu
2015-11-25 19:21     ` Jan Hubicka
2015-11-25 23:09       ` Jan Hubicka
2015-11-25 23:56         ` Jan Hubicka
2015-11-28 10:35         ` Tom de Vries
2015-11-28 12:03           ` Tom de Vries
2015-11-28 16:05             ` Ilya Verbin
2015-11-28 17:41               ` Tom de Vries
2015-11-29 21:15                 ` Jan Hubicka [this message]
2015-11-25 18:54   ` Jan Hubicka
2015-11-26 10:15     ` Richard Biener
2015-11-26 20:30       ` Jan Hubicka
2015-11-25 23:59   ` Andi Kleen
2015-11-26  0:24 ` Andi Kleen
2015-11-26  0:54   ` Jan Hubicka
2015-11-26  1:55     ` Andi Kleen
2015-11-26  2:02       ` Jan Hubicka
2015-11-26  2:12         ` Andi Kleen
2015-11-26  6:33           ` Jan Hubicka
2015-11-26 10:33     ` Richard Biener
2016-03-16 17:33 ` H.J. Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151129200317.GB10284@kam.mff.cuni.cz \
    --to=hubicka@ucw.cz \
    --cc=Tom_deVries@mentor.com \
    --cc=ak@linux.intel.com \
    --cc=ccoutant@google.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=hjl.tools@gmail.com \
    --cc=iant@google.com \
    --cc=iverbin@gmail.com \
    --cc=kirill.yukhin@gmail.com \
    --cc=rguenther@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).