From: Marek Polacek <polacek@redhat.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Jakub Jelinek <jakub@redhat.com>,
Richard Biener <rguenther@suse.de>
Subject: Re: [PATCH] Add save_expr langhook (PR c/68513)
Date: Mon, 30 Nov 2015 12:58:00 -0000 [thread overview]
Message-ID: <20151130123755.GD28072@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1511272226590.21173@digraph.polyomino.org.uk>
On Fri, Nov 27, 2015 at 10:43:42PM +0000, Joseph Myers wrote:
> On Fri, 27 Nov 2015, Marek Polacek wrote:
>
> > I didn't know where to put setting of in_late_processing. With the current
> > placement, we won't (for valid programs) call c_save_expr from c_genericize
> > or c_gimplify_expr.
>
> Well, the placement in this patch (in c_parser_compound_statement) is
> certainly wrong. It doesn't even save and restore, so after one compound
> statement inside another, parsing would continue with in_late_processing
> wrongly set. And c_save_expr is logically right for any parsing outside
> compound statements as well (arbitrary expressions can occur in sizeof
> outside functions and in VLA parameter sizes and should follow the normal
> rules for what's a constant expression - there's a known bug that
> statement expressions are wrongly rejected in such contexts).
Indeed. I don't know what I was thinking. :/
> Starting from first principles: parsing takes place from within
> c_parse_file as the sole external entry point to the parser. So you could
> have a parsing_input variable that starts off as false, and where
> c_parse_file saves it, sets to true, and restores the saved value at the
> end. Then you'd use c_save_expr if parsing_input && !in_late_binary_op.
>
> If that doesn't work, it means there are cases where the hook gets called
> from folding that takes place during parsing, on expressions that will not
> subsequently go through c_fully_fold, but without in_late_binary_op set.
> Knowing what those cases are might help work out any fix for them that is
> needed.
I'm not sanguine about doing this reliably in stage3. I think I'll try the
other approach mentioned later in this thread.
> > I suppose I should also modify save_expr in fold-const.c to call it via the
> > langhook, if this approach is sane. Dunno.
>
> That's a complication. When the folding is taking place from within
> c_fully_fold (and so the sub-expressions have already been folded, and had
> their C_MAYBE_CONST_EXPRs removed, and the result of folding will not be
> re-folded), it should be using save_expr not c_save_expr. So maybe the
> hook needs to say: use c_save_expr, if parsing, not in_late_binary_op and
> not folding from within c_fully_fold.
Oh, I see :(.
> Again long term we should aim for the representation during parsing not to
> need SAVE_EXPRs and for the folding that creates them (and the other
> folding for optimization in general) to happen only after parsing....
Yeah, let's strike that for gcc7.
Thanks,
Marek
next prev parent reply other threads:[~2015-11-30 12:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-27 19:02 Marek Polacek
2015-11-27 19:36 ` Marek Polacek
2015-11-27 23:56 ` Joseph Myers
2015-11-30 12:58 ` Marek Polacek [this message]
2015-11-28 8:38 ` Richard Biener
2015-11-28 16:19 ` Joseph Myers
2015-11-30 15:41 ` Marek Polacek
2015-11-30 15:51 ` Marek Polacek
2015-11-30 16:00 ` Richard Biener
2015-11-30 16:06 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151130123755.GD28072@redhat.com \
--to=polacek@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=joseph@codesourcery.com \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).