public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Marek Polacek <polacek@redhat.com>
To: Richard Biener <rguenther@suse.de>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
	       Joseph Myers <joseph@codesourcery.com>,
	       Jakub Jelinek <jakub@redhat.com>
Subject: Re: [PATCH] Add save_expr langhook (PR c/68513)
Date: Mon, 30 Nov 2015 15:51:00 -0000	[thread overview]
Message-ID: <20151130154143.GF28072@redhat.com> (raw)
In-Reply-To: <43651703-7ABE-491D-8D5B-863E921EA365@suse.de>

On Sat, Nov 28, 2015 at 08:50:12AM +0100, Richard Biener wrote:
> Different approach: after the FE folds (unexpectedly?), scan the result for
> SAVE_EXPRs and if found, drop the folding.

Neither this fixes this problem completely, because we simply don't know where
those SAVE_EXPRs might be introduced: it might be convert(), but e.g. when I
changed the original testcase a tiny bit (added -), then those SAVE_EXPRs were
introduced in a different spot (via c_process_stmt_expr -> c_fully_fold).

	Marek

  parent reply	other threads:[~2015-11-30 15:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-27 19:02 Marek Polacek
2015-11-27 19:36 ` Marek Polacek
2015-11-27 23:56 ` Joseph Myers
2015-11-30 12:58   ` Marek Polacek
2015-11-28  8:38 ` Richard Biener
2015-11-28 16:19   ` Joseph Myers
2015-11-30 15:41     ` Marek Polacek
2015-11-30 15:51   ` Marek Polacek [this message]
2015-11-30 16:00     ` Richard Biener
2015-11-30 16:06       ` Richard Biener

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151130154143.GF28072@redhat.com \
    --to=polacek@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@redhat.com \
    --cc=joseph@codesourcery.com \
    --cc=rguenther@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).