From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 119747 invoked by alias); 2 Dec 2015 13:39:11 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 119690 invoked by uid 89); 2 Dec 2015 13:39:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.0 required=5.0 tests=AWL,BAYES_50,KAM_ASCII_DIVIDERS,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 02 Dec 2015 13:39:09 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id D5B39C05E140; Wed, 2 Dec 2015 13:39:07 +0000 (UTC) Received: from localhost (ovpn-116-29.ams2.redhat.com [10.36.116.29]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tB2Dd6nZ021870; Wed, 2 Dec 2015 08:39:07 -0500 Date: Wed, 02 Dec 2015 13:39:00 -0000 From: Jonathan Wakely To: Jason Merrill Cc: "Moore, Catherine" , Richard Henderson , "gcc-patches@gcc.gnu.org" , Matthew Fortune Subject: Re: [RFA] Compact EH Patch Message-ID: <20151202133906.GE11200@redhat.com> References: <55FC6505.8040203@redhat.com> <565E122D.3000106@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <565E122D.3000106@redhat.com> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.5.24 (2015-08-30) X-SW-Source: 2015-12/txt/msg00258.txt.bz2 On 01/12/15 16:33 -0500, Jason Merrill wrote: >On 11/25/2015 11:58 AM, Moore, Catherine wrote: >> >> >>>-----Original Message----- >>>From: Richard Henderson [mailto:rth@redhat.com] >>>Sent: Friday, September 18, 2015 3:25 PM >>>To: Moore, Catherine; gcc-patches@gcc.gnu.org >>>Cc: jason@redhat.com; Matthew Fortune >>>Subject: Re: [RFA] Compact EH Patch >>> >>>>Index: libgcc/libgcc-std.ver.in >>>> >>>========================================================== >>>========= >>>>--- libgcc/libgcc-std.ver.in (revision 226409) >>>>+++ libgcc/libgcc-std.ver.in (working copy) >>>>@@ -1918,6 +1918,7 @@ GCC_4.6.0 { >>>> __morestack_current_segment >>>> __morestack_initial_sp >>>> __splitstack_find >>>>+ _Unwind_GetEhEncoding >>>> } >>>> >>>> %inherit GCC_4.7.0 GCC_4.6.0 >>>>@@ -1938,3 +1939,8 @@ GCC_4.7.0 { >>>> %inherit GCC_4.8.0 GCC_4.7.0 >>>> GCC_4.8.0 { >>>> } >>>>+ >>>>+%inherit GCC_4.8.0 GCC_4.7.0 >>>>+GCC_4.8.0 { >>>>+ __register_frame_info_header_bases >>>>+} >>> >>>You can't push new symbols into old versions. These have to go into the >>>version for the current gcc. >>> >>>>Index: libstdc++-v3/config/abi/pre/gnu.ver >>>> >>>========================================================== >>>========= >>>>--- libstdc++-v3/config/abi/pre/gnu.ver (revision 226409) >>>>+++ libstdc++-v3/config/abi/pre/gnu.ver (working copy) >>>>@@ -1909,6 +1909,7 @@ CXXABI_1.3 { >>>> __gxx_personality_v0; >>>> __gxx_personality_sj0; >>>> __gxx_personality_seh0; >>>>+ __gnu_compact_pr2; >>>> __dynamic_cast; >>>> >>>> # *_type_info classes, ctor and dtor >>>>Index: libstdc++-v3/config/abi/pre/gnu-versioned-namespace.ver >>>> >>>========================================================== >>>========= >>>>--- libstdc++-v3/config/abi/pre/gnu-versioned-namespace.ver >>> (revision 226409) >>>>+++ libstdc++-v3/config/abi/pre/gnu-versioned-namespace.ver >>> (working copy) >>>>@@ -200,6 +200,7 @@ CXXABI_2.0 { >>>> __cxa_vec_new; >>>> __gxx_personality_v0; >>>> __gxx_personality_sj0; >>>>+ __gnu_compact_pr2; >>>> __dynamic_cast; >>>> >>>> # std::exception_ptr >>> >>>Likewise. >>> >>I'm getting ready to post the updates to this patch -- hopefully, I can still get it in GCC 6.0. >>I'm not sure how to tell what the current CXXABI is for these two files. Should it be CXXABI_2.0 for both of these? > >Jonathan, can you answer this question? It's OK to add to CXXABI_2.0 for the gnu-versioned-namespace file, when you configure libstdc++ to use the versioned namespaces you're explicitly requesting no ABI compatibility, and everything gets the same version. For gnu.ver you need to create a new symbol version and add new symbols in there. CXXABI_1.3.9 was present in GCC 5, so you need to create CXXABI_1.3.10 for your new symbol. CXXABI_1.3.10 { __gnu_compact_pr2; } CXXABI_1.3.9;