From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 129577 invoked by alias); 2 Dec 2015 19:28:47 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 129557 invoked by uid 89); 2 Dec 2015 19:28:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: troutmask.apl.washington.edu Received: from troutmask.apl.washington.edu (HELO troutmask.apl.washington.edu) (128.95.76.21) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 02 Dec 2015 19:28:45 +0000 Received: from troutmask.apl.washington.edu (localhost [127.0.0.1]) by troutmask.apl.washington.edu (8.15.2/8.15.2) with ESMTPS id tB2JSegH088900 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 2 Dec 2015 11:28:40 -0800 (PST) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.15.2/8.15.2/Submit) id tB2JScgY088483; Wed, 2 Dec 2015 11:28:38 -0800 (PST) (envelope-from sgk) Date: Wed, 02 Dec 2015 19:28:00 -0000 From: Steve Kargl To: Cesar Philippidis Cc: Thomas Schwinge , Julian Brown , GCC Patches , Jakub Jelinek , James Norris , "Joseph S. Myers" , Nathan Sidwell , Fortran List Subject: Re: [OpenACC 0/7] host_data construct Message-ID: <20151202192838.GA66706@troutmask.apl.washington.edu> References: <20151026183422.GW478@tucnak.redhat.com> <20151102183339.365c3d33@octopus> <20151112111621.657650bc@octopus> <20151118124747.30a2ec5d@octopus> <20151119131345.GX5675@tucnak.redhat.com> <20151119142650.5a8842e4@octopus> <20151119155723.GA5675@tucnak.redhat.com> <20151130193034.71143aa4@octopus> <877fkwn8p6.fsf@kepler.schwinge.homeip.net> <565F437A.6090103@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <565F437A.6090103@codesourcery.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-SW-Source: 2015-12/txt/msg00353.txt.bz2 On Wed, Dec 02, 2015 at 11:16:10AM -0800, Cesar Philippidis wrote: > > This host_data patch exposed a bug in the fortran front end where it was > allowing arrays to be used as reduction variables. If replace you > replace codimension with dimension, you'd see a similar ICE. The > attached patch, while it doesn't make any attempt to fix the gimplifier > changes, does teach the fortran front end to error on acc reductions > containing array variables. > > Note that this solution is somewhat aggressive because we probably > should allow reductions on individual array elements. E.g. > > !$acc loop reduction(+:var(1)) > > The c and c++ front ends also have that problem. Maybe I'll revisit this > later. > > Is this ok for trunk? It will close pr63861. > I think that it is OK, but will defer to Jakub or Thomas. I suspect tht Jakub may be pre-occupied with the upcoming 5.3 release. -- Steve