From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 33887 invoked by alias); 2 Dec 2015 19:35:11 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 33869 invoked by uid 89); 2 Dec 2015 19:35:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 02 Dec 2015 19:35:09 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id D00D796C1; Wed, 2 Dec 2015 19:35:07 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-116-34.ams2.redhat.com [10.36.116.34]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tB2JZ6Wg013179 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 2 Dec 2015 14:35:07 -0500 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id tB2JZ3Eu015569; Wed, 2 Dec 2015 20:35:04 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id tB2JZ2Q9015568; Wed, 2 Dec 2015 20:35:02 +0100 Date: Wed, 02 Dec 2015 19:35:00 -0000 From: Jakub Jelinek To: Cesar Philippidis Cc: Thomas Schwinge , Julian Brown , GCC Patches , James Norris , "Joseph S. Myers" , Nathan Sidwell , Fortran List Subject: Re: [OpenACC 0/7] host_data construct Message-ID: <20151202193502.GY5675@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <20151026183422.GW478@tucnak.redhat.com> <20151102183339.365c3d33@octopus> <20151112111621.657650bc@octopus> <20151118124747.30a2ec5d@octopus> <20151119131345.GX5675@tucnak.redhat.com> <20151119142650.5a8842e4@octopus> <20151119155723.GA5675@tucnak.redhat.com> <20151130193034.71143aa4@octopus> <877fkwn8p6.fsf@kepler.schwinge.homeip.net> <565F437A.6090103@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <565F437A.6090103@codesourcery.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2015-12/txt/msg00354.txt.bz2 On Wed, Dec 02, 2015 at 11:16:10AM -0800, Cesar Philippidis wrote: > > --- gcc/testsuite/gfortran.dg/goacc/coarray_2.f90 > > +++ gcc/testsuite/gfortran.dg/goacc/coarray_2.f90 > > @@ -3,6 +3,7 @@ > > ! > > ! PR fortran/63861 > > ! { dg-xfail-if "" { *-*-* } } > > +! { dg-excess-errors "TODO" } > > This host_data patch exposed a bug in the fortran front end where it was > allowing arrays to be used as reduction variables. If replace you > replace codimension with dimension, you'd see a similar ICE. The > attached patch, while it doesn't make any attempt to fix the gimplifier > changes, does teach the fortran front end to error on acc reductions > containing array variables. Does the OpenACC standard disallow array reductions? Just asking, because OpenMP allows them (up to 4.0 only in Fortran, in 4.5 also C/C++ array sections are allowed). If the OpenACC standard disallows them, then it is desirable to reject them and the patch is ok, otherwise you should try harder to support them ;). Jakub