public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Tobias Burnus <tobias.burnus@physik.fu-berlin.de>
To: gcc-patches@gcc.gnu.org
Cc: "Manuel López-Ibáñez" <manu@gcc.gnu.org>
Subject: Re: PR c/68657 - Add missing 'Warning' flags to c-family/c.opt + java/lang.opt
Date: Fri, 04 Dec 2015 10:00:00 -0000	[thread overview]
Message-ID: <20151204100028.GA5781@physik.fu-berlin.de> (raw)
In-Reply-To: <20151204095928.GB1250@physik.fu-berlin.de>

[-- Attachment #1: Type: text/plain, Size: 542 bytes --]

And now with attached patch ...

On Fri, Dec 04, 2015 at 10:59:29AM +0100, Tobias Burnus wrote:
> A few warning options lack the 'Warning' flag, which since r228094 (2015-09-24)
> has the effect that -W(no-)error= doesn't work for them. Additionally,
> --help=warnings doesn't work for them either.
> 
> Successfully bootstrapped with c,c++,fortran,lto,go,objc,obj-c++,java on
> x86-64-gnu-linux & checked whether the issue in the PR was fixed.
> 
> I intent to commit the patch tomorrow as obvious unless someone has objections.
> 
> Tobias

[-- Attachment #2: gcc-warn.diff --]
[-- Type: text/x-diff, Size: 2212 bytes --]

gcc/c-family/
	PR c/68657
	* c.opt (Wpsabi, Wfloat-conversion, Wsign-conversion):
	Add 'Warning' flag.

gcc/java/
	PR c/68657
	* lang.opt (Wdeprecated, Wextraneous-semicolon, Wout-of-date,
	Wredundant-modifiers): Add 'Warning' flag.

diff --git a/gcc/c-family/c.opt b/gcc/c-family/c.opt
index aafd802..758f88f 100644
--- a/gcc/c-family/c.opt
+++ b/gcc/c-family/c.opt
@@ -267,3 +267,3 @@ Warn if a subobject has an abi_tag attribute that the complete object type does
 Wpsabi
-C ObjC C++ ObjC++ LTO Var(warn_psabi) Init(1) Undocumented LangEnabledBy(C ObjC C++ ObjC++,Wabi)
+C ObjC C++ ObjC++ LTO Var(warn_psabi) Init(1) Undocumented Warning LangEnabledBy(C ObjC C++ ObjC++,Wabi)
 
@@ -437,3 +437,3 @@ This switch is deprecated; use -Werror=implicit-function-declaration instead.
 Wfloat-conversion
-C ObjC C++ ObjC++ Var(warn_float_conversion) LangEnabledBy(C ObjC C++ ObjC++,Wconversion)
+C ObjC C++ ObjC++ Var(warn_float_conversion) Warning LangEnabledBy(C ObjC C++ ObjC++,Wconversion)
 Warn for implicit type conversions that cause loss of floating point precision.
@@ -839,3 +839,3 @@ C ObjC C++ ObjC++ EnabledBy(Wextra)
 Wsign-conversion
-C ObjC C++ ObjC++ Var(warn_sign_conversion) LangEnabledBy(C ObjC,Wconversion)
+C ObjC C++ ObjC++ Var(warn_sign_conversion) Warning LangEnabledBy(C ObjC,Wconversion)
 Warn for implicit type conversions between signed and unsigned integers.
diff --git a/gcc/java/lang.opt b/gcc/java/lang.opt
index 7399d57..9fd2580 100644
--- a/gcc/java/lang.opt
+++ b/gcc/java/lang.opt
@@ -116,3 +116,3 @@ Java
 Wdeprecated
-Java Var(warn_deprecated)
+Java Var(warn_deprecated) Warning
 ; Documented for C
@@ -120,3 +120,3 @@ Java Var(warn_deprecated)
 Wextraneous-semicolon
-Java Var(flag_extraneous_semicolon)
+Java Var(flag_extraneous_semicolon) Warning
 Warn if deprecated empty statements are found.
@@ -124,3 +124,3 @@ Warn if deprecated empty statements are found.
 Wout-of-date
-Java Var(flag_newer) Init(1)
+Java Var(flag_newer) Init(1) Warning
 Warn if .class files are out of date.
@@ -128,3 +128,3 @@ Warn if .class files are out of date.
 Wredundant-modifiers
-Java Var(flag_redundant)
+Java Var(flag_redundant) Warning
 Warn if modifiers are specified when not necessary.

  reply	other threads:[~2015-12-04 10:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-04  9:59 Tobias Burnus
2015-12-04 10:00 ` Tobias Burnus [this message]
2015-12-04 18:52   ` Jeff Law

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151204100028.GA5781@physik.fu-berlin.de \
    --to=tobias.burnus@physik.fu-berlin.de \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=manu@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).