PR c/68657 - Add missing 'Warning' flags to c-family/c.opt + java/lang.opt

PR c/68657 - Add missing 'Warning' flags to c-family/c.opt + java/lang.opt

[Tobias Burnus]

A few warning options lack the 'Warning' flag, which since r228094 (2015-09-24)
has the effect that -W(no-)error= doesn't work for them. Additionally,
--help=warnings doesn't work for them either.

Successfully bootstrapped with c,c++,fortran,lto,go,objc,obj-c++,java on
x86-64-gnu-linux & checked whether the issue in the PR was fixed.

I intent to commit the patch tomorrow as obvious unless someone has objections.

Tobias

Re: PR c/68657 - Add missing 'Warning' flags to c-family/c.opt + java/lang.opt

[Tobias Burnus]

[-- Attachment #1: Type: text/plain, Size: 542 bytes --]

And now with attached patch ...

On Fri, Dec 04, 2015 at 10:59:29AM +0100, Tobias Burnus wrote:
> A few warning options lack the 'Warning' flag, which since r228094 (2015-09-24)
> has the effect that -W(no-)error= doesn't work for them. Additionally,
> --help=warnings doesn't work for them either.
> 
> Successfully bootstrapped with c,c++,fortran,lto,go,objc,obj-c++,java on
> x86-64-gnu-linux & checked whether the issue in the PR was fixed.
> 
> I intent to commit the patch tomorrow as obvious unless someone has objections.
> 
> Tobias

[-- Attachment #2: gcc-warn.diff --]
[-- Type: text/x-diff, Size: 2212 bytes --]

gcc/c-family/
	PR c/68657
	* c.opt (Wpsabi, Wfloat-conversion, Wsign-conversion):
	Add 'Warning' flag.

gcc/java/
	PR c/68657
	* lang.opt (Wdeprecated, Wextraneous-semicolon, Wout-of-date,
	Wredundant-modifiers): Add 'Warning' flag.

diff --git a/gcc/c-family/c.opt b/gcc/c-family/c.opt
index aafd802..758f88f 100644
--- a/gcc/c-family/c.opt
+++ b/gcc/c-family/c.opt
@@ -267,3 +267,3 @@ Warn if a subobject has an abi_tag attribute that the complete object type does
 Wpsabi
-C ObjC C++ ObjC++ LTO Var(warn_psabi) Init(1) Undocumented LangEnabledBy(C ObjC C++ ObjC++,Wabi)
+C ObjC C++ ObjC++ LTO Var(warn_psabi) Init(1) Undocumented Warning LangEnabledBy(C ObjC C++ ObjC++,Wabi)
 
@@ -437,3 +437,3 @@ This switch is deprecated; use -Werror=implicit-function-declaration instead.
 Wfloat-conversion
-C ObjC C++ ObjC++ Var(warn_float_conversion) LangEnabledBy(C ObjC C++ ObjC++,Wconversion)
+C ObjC C++ ObjC++ Var(warn_float_conversion) Warning LangEnabledBy(C ObjC C++ ObjC++,Wconversion)
 Warn for implicit type conversions that cause loss of floating point precision.
@@ -839,3 +839,3 @@ C ObjC C++ ObjC++ EnabledBy(Wextra)
 Wsign-conversion
-C ObjC C++ ObjC++ Var(warn_sign_conversion) LangEnabledBy(C ObjC,Wconversion)
+C ObjC C++ ObjC++ Var(warn_sign_conversion) Warning LangEnabledBy(C ObjC,Wconversion)
 Warn for implicit type conversions between signed and unsigned integers.
diff --git a/gcc/java/lang.opt b/gcc/java/lang.opt
index 7399d57..9fd2580 100644
--- a/gcc/java/lang.opt
+++ b/gcc/java/lang.opt
@@ -116,3 +116,3 @@ Java
 Wdeprecated
-Java Var(warn_deprecated)
+Java Var(warn_deprecated) Warning
 ; Documented for C
@@ -120,3 +120,3 @@ Java Var(warn_deprecated)
 Wextraneous-semicolon
-Java Var(flag_extraneous_semicolon)
+Java Var(flag_extraneous_semicolon) Warning
 Warn if deprecated empty statements are found.
@@ -124,3 +124,3 @@ Warn if deprecated empty statements are found.
 Wout-of-date
-Java Var(flag_newer) Init(1)
+Java Var(flag_newer) Init(1) Warning
 Warn if .class files are out of date.
@@ -128,3 +128,3 @@ Warn if .class files are out of date.
 Wredundant-modifiers
-Java Var(flag_redundant)
+Java Var(flag_redundant) Warning
 Warn if modifiers are specified when not necessary.

Re: PR c/68657 - Add missing 'Warning' flags to c-family/c.opt + java/lang.opt

[Jeff Law]

On 12/04/2015 03:00 AM, Tobias Burnus wrote:
> And now with attached patch ...
>
> On Fri, Dec 04, 2015 at 10:59:29AM +0100, Tobias Burnus wrote:
>> A few warning options lack the 'Warning' flag, which since r228094 (2015-09-24)
>> has the effect that -W(no-)error= doesn't work for them. Additionally,
>> --help=warnings doesn't work for them either.
>>
>> Successfully bootstrapped with c,c++,fortran,lto,go,objc,obj-c++,java on
>> x86-64-gnu-linux & checked whether the issue in the PR was fixed.
>>
>> I intent to commit the patch tomorrow as obvious unless someone has objections.
No objections, it looks fine to me.

jeff