From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28568 invoked by alias); 11 Dec 2015 11:59:08 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 28546 invoked by uid 89); 11 Dec 2015 11:59:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 11 Dec 2015 11:59:06 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id BD140C105B2F; Fri, 11 Dec 2015 11:59:04 +0000 (UTC) Received: from localhost (ovpn-116-26.ams2.redhat.com [10.36.116.26]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tBBBx3K1018445; Fri, 11 Dec 2015 06:59:03 -0500 Date: Fri, 11 Dec 2015 11:59:00 -0000 From: Jonathan Wakely To: DJ Delorie Cc: Jeff Law , andris.pavenis@wippies.com, gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org Subject: Re: [PATCH 1/6] [DJGPP] libstdc++-v3/config/os/djgpp/error_constants.h: Update according to errno codes available for DJGPP Message-ID: <20151211115903.GF5356@redhat.com> References: <56631268.2020109@iki.fi> <56632EC3.3080506@wippies.com> <5669FE05.5050305@redhat.com> <201512102258.tBAMwbg7020855@greed.delorie.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <201512102258.tBAMwbg7020855@greed.delorie.com> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.5.24 (2015-08-30) X-SW-Source: 2015-12/txt/msg01253.txt.bz2 On 10/12/15 17:58 -0500, DJ Delorie wrote: > >> I can't really judge this one. Either DJ or Jon would need to some in >> on this. > >Looks OK to me, although in the default configuration (plain DJGPP) >the #ifdefs will always be false (omitted), which is harmless. Is there a non-default configuration where they are true? I've been wavering on approving this patch, not because there's anything wrong with it, but because I'm still ruminating on https://gcc.gnu.org/ml/gcc-patches/2015-11/msg01458.html I think I'm going to make that change for mingw-w64, but either way the DJGPP patch is OK for trunk (assuming there is some non-default configuration where it actually does something useful).