From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: rdsandiford@googlemail.com (Richard Sandiford)
Cc: vogt@linux.vnet.ibm.com, gcc-patches@gcc.gnu.org,
Ulrich.Weigand@de.ibm.com (Ulrich Weigand),
krebbel@linux.vnet.ibm.com (Andreas Krebbel)
Subject: Re: [PATCH] S/390: Wide int support.
Date: Wed, 16 Dec 2015 00:24:00 -0000 [thread overview]
Message-ID: <20151216002406.4517713EE@oc7340732750.ibm.com> (raw)
In-Reply-To: <877fkfmqzz.fsf@googlemail.com> from "Richard Sandiford" at Dec 15, 2015 07:49:36 PM
Richard Sandiford wrote:
> "Ulrich Weigand" <uweigand@de.ibm.com> writes:
> > The problem is not DImode LABEL_REFs, but rather VOIDmode LABEL_REFs when
> > matched against a match_operand:DI.
>
> It'd be good to fix this in a more direct way though, rather than
> hack around it. It's possible that the trick will stop working
> if genrecog.c gets smarter.
>
> When do label_refs have VOIDmode? Is this an m31-ism?
No, this seems to be a cross-platform issue. For one, RTX in .md files
pretty much consistently uses (label_ref ...) without a mode. This means
that any LABEL_REFs generated from .md file expanders or splitters will
use VOIDmode.
For LABEL_REFs generated via explicit gen_rtx_LABEL_REF, usage seems to
be mixed between using VOIDmode and Pmode in target C++ files. Common
code does seem to be using always Pmode, as far as I can see.
Are LABEL_REFs in fact supposed to always have Pmode?
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2015-12-16 0:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-11 14:20 Dominik Vogt
2015-12-11 14:33 ` Ulrich Weigand
2015-12-15 19:49 ` Richard Sandiford
2015-12-16 0:24 ` Ulrich Weigand [this message]
2015-12-18 9:53 ` Richard Sandiford
2015-12-11 14:44 ` Andreas Krebbel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151216002406.4517713EE@oc7340732750.ibm.com \
--to=uweigand@de.ibm.com \
--cc=Ulrich.Weigand@de.ibm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=krebbel@linux.vnet.ibm.com \
--cc=rdsandiford@googlemail.com \
--cc=vogt@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).