From: Martin Jambor <mjambor@suse.cz>
To: Yury Gribov <y.gribov@samsung.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH 4/5] Fix intransitive comparison in compare_access_positions
Date: Thu, 17 Dec 2015 14:58:00 -0000 [thread overview]
Message-ID: <20151217145833.GK3534@virgil.suse.cz> (raw)
In-Reply-To: <56727A13.6030609@samsung.com>
Hi,
On Thu, Dec 17, 2015 at 12:02:11PM +0300, Yury Gribov wrote:
> Another intransitive comparison in reload_pseudo_compare_func. Buggy
> scenario:
> 1) A and B are ints of equal presion so we return 0
> 2) C is REAL and thus can compare differently to A and B
>
> Cc-ing Martin who's the original author.
I cannot approve it but I also do not object to this change.
Thanks,
Martin
>
> /Yury
> From 6f3930ad81945f6b5d7aecfdda16089547a592d3 Mon Sep 17 00:00:00 2001
> From: Yury Gribov <tetra2005@gmail.com>
> Date: Sat, 12 Dec 2015 10:39:15 +0300
> Subject: [PATCH 4/5] Fix intransitive comparison in compare_access_positions.
>
> 2015-12-17 Yury Gribov <tetra2005@gmail.com>
>
> * tree-sra.c (compare_access_positions):
> Make transitive.
>
next prev parent reply other threads:[~2015-12-17 14:58 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-17 8:55 [PATCH 0/5] Fix qsort comparison functions Yury Gribov
2015-12-17 8:58 ` [PATCH 1/5] Fix asymmetric " Yury Gribov
2015-12-17 11:39 ` Jakub Jelinek
2015-12-17 12:04 ` Yury Gribov
2015-12-18 19:40 ` Yury Gribov
2015-12-18 20:07 ` Jakub Jelinek
2015-12-18 20:09 ` Yury Gribov
2015-12-17 11:41 ` Richard Biener
2015-12-17 11:47 ` Yury Gribov
2015-12-17 11:57 ` Jakub Jelinek
2015-12-17 11:59 ` Richard Biener
2015-12-17 12:14 ` Yury Gribov
2015-12-17 12:25 ` Richard Biener
2015-12-17 12:36 ` Yury Gribov
2015-12-17 11:59 ` Andrey Belevantsev
2015-12-17 12:12 ` Yury Gribov
2015-12-17 12:48 ` Andrey Belevantsev
2015-12-17 19:39 ` Andrew Pinski
2015-12-17 22:00 ` Jason Merrill
2015-12-17 8:59 ` [PATCH 2/5] Fix more " Yury Gribov
2015-12-17 9:00 ` [PATCH 3/5] "Fix" intransitive comparison in reload_pseudo_compare_func Yury Gribov
2015-12-17 19:36 ` Vladimir Makarov
2015-12-18 19:50 ` Yury Gribov
2015-12-17 9:02 ` [PATCH 4/5] Fix intransitive comparison in compare_access_positions Yury Gribov
2015-12-17 14:58 ` Martin Jambor [this message]
2015-12-17 9:03 ` [PATCH 5/5] Fix intransitive comparison in dr_group_sort_cmp Yury Gribov
2015-12-17 11:57 ` Richard Biener
2015-12-17 12:33 ` Yury Gribov
2015-12-17 12:51 ` Richard Biener
2015-12-18 20:19 ` Yury Gribov
2015-12-18 22:30 ` Yuri Gribov
2015-12-25 11:42 ` Yury Gribov
2016-01-08 8:23 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151217145833.GK3534@virgil.suse.cz \
--to=mjambor@suse.cz \
--cc=gcc-patches@gcc.gnu.org \
--cc=y.gribov@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).