From: Jan Hubicka <hubicka@ucw.cz>
To: Nathan Sidwell <nathan@acm.org>
Cc: Jan Hubicka <hubicka@ucw.cz>, GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: stop IPA wrapping 'main'
Date: Thu, 17 Dec 2015 21:01:00 -0000 [thread overview]
Message-ID: <20151217210106.GB93506@kam.mff.cuni.cz> (raw)
In-Reply-To: <5673016F.8060105@acm.org>
> gcc.dg/20031102-1.c now causes some 'surprising' optimization
> behaviour. It is essentially
>
> int FooBar(void)
> {
> ... stuff
> return 0;
> }
>
> int main(void)
> {
> return FooBar();
> }
>
>
> What happens is that FooBar gets inlined into main, and then
> ipa-icf notices FooBar and main have identical bodies. It chooses
> to have FooBar tail call main, which results in a surprising call
> of 'main'. On PTX this is particularly unfortunate because we have
> to emit a single prototype for main with the regular argc and argv
> arguments (the backend gets around 'int main (void)' by faking the
> additional 2 args). But that fails here because the tail call
> doesn't match the prototype.
>
> Anyway, picking 'main' as the source function struck me as a poor
> choice, hence the attached patch. It picks the second function of a
> congruent set, if the first is 'main'. Note that even on, say
> x86-linux, we emit a tail call rather than an alias for the included
> testcase.
>
> I removed the gcc_assert, as the vector indexing operator already
> checks the subscript is within range.
>
> Alternatively I could probably just fixup the testcase to make
> FooBar uninlinable, as I suspect that might have been the original
> intent.
>
> tested on x86_64-linux and ptx-none.
>
> nathan
> 2015-12-17 Nathan Sidwell <nathan@acm.org>
>
> gcc/
> * ipa-icf.c (sem_item_optimizer::merge): Don't pick 'main' as the
> source function.
>
> gcc/testsuite/
> * gcc.dg/ipa/ipa-icf-merge-1.c: New.
OK, thanks. Indeed we should not introduce new calls to main :)
It contains some magic stuff on x86 targets, too.
Honza
prev parent reply other threads:[~2015-12-17 21:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-17 18:39 Nathan Sidwell
2015-12-17 21:01 ` Jan Hubicka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151217210106.GB93506@kam.mff.cuni.cz \
--to=hubicka@ucw.cz \
--cc=gcc-patches@gcc.gnu.org \
--cc=nathan@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).