From: Steve Kargl <sgk@troutmask.apl.washington.edu>
To: Gerald Pfeifer <gerald@pfeifer.com>
Cc: "H.J. Lu" <hjl.tools@gmail.com>,
Paul Richard Thomas <paul.richard.thomas@gmail.com>,
fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] (Partial) Implementation of simplificaiton of CSHIFT
Date: Thu, 31 Dec 2015 16:13:00 -0000 [thread overview]
Message-ID: <20151231161334.GA11994@troutmask.apl.washington.edu> (raw)
In-Reply-To: <alpine.LSU.2.20.1512291725490.5144@anthias>
On Thu, Dec 31, 2015 at 09:57:10PM +0800, Gerald Pfeifer wrote:
> On Sat, 21 Nov 2015, Steve Kargl wrote:
> > 2015-11-21 Steven G. Kargl <kargl@gcc.gnu.org>
> >
> > * simplify.c (gfc_simplify_cshift): Work around bootstrap issues
> > due to inappropriate warning options.
>
> > Index: simplify.c
> > ===================================================================
> > + /* GCC bootstrap is too stupid to realize that the above code for dm
> > + is correct. First, dim can be specified for a rank 1 array. It is
> > + not needed in this nor used here. Second, the code is simply waiting
> > + for someone to implement rank > 1 simplification. For now, add a
> > + pessimization to the code that has a zero valid reason to be here. */
> > + if (dm > array->rank)
> > + gcc_unreachable ();
>
> I'm not sure this comment is appropriate as is. At a minimum, it
> should list the version of GCC this was introduced for/with. So,
> something like
>
I have no intention to change the comment.
--
Steve
next prev parent reply other threads:[~2015-12-31 16:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-20 0:58 Steve Kargl
2015-11-20 1:31 ` Steve Kargl
2015-11-20 3:16 ` Steve Kargl
2015-11-20 20:09 ` Steve Kargl
2015-11-21 11:45 ` Paul Richard Thomas
2015-11-21 18:07 ` Steve Kargl
2015-11-21 18:12 ` H.J. Lu
2015-11-21 18:21 ` Steve Kargl
2015-11-21 19:26 ` H.J. Lu
2015-11-21 20:00 ` Steve Kargl
2015-11-21 20:22 ` Steve Kargl
2015-11-21 22:39 ` Eric Botcazou
2015-11-22 1:53 ` Steve Kargl
2015-12-31 14:00 ` Gerald Pfeifer
2015-12-31 16:13 ` Steve Kargl [this message]
2015-11-21 20:30 Dominique d'Humières
2015-11-21 21:50 ` Steve Kargl
2015-11-22 9:14 ` Dominique d'Humières
2015-11-22 16:57 ` Steve Kargl
2015-11-22 18:41 ` Dominique d'Humières
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151231161334.GA11994@troutmask.apl.washington.edu \
--to=sgk@troutmask.apl.washington.edu \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=gerald@pfeifer.com \
--cc=hjl.tools@gmail.com \
--cc=paul.richard.thomas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).