From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8770 invoked by alias); 31 Dec 2015 16:13:40 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 8741 invoked by uid 89); 31 Dec 2015 16:13:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=intention, Hx-languages-length:1067, H*r:sgk, Gerald X-Spam-User: qpsmtpd, 2 recipients X-HELO: troutmask.apl.washington.edu Received: from troutmask.apl.washington.edu (HELO troutmask.apl.washington.edu) (128.95.76.21) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 31 Dec 2015 16:13:39 +0000 Received: from troutmask.apl.washington.edu (localhost [127.0.0.1]) by troutmask.apl.washington.edu (8.15.2/8.15.2) with ESMTPS id tBVGDZUl012039 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 31 Dec 2015 08:13:35 -0800 (PST) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.15.2/8.15.2/Submit) id tBVGDYEg012038; Thu, 31 Dec 2015 08:13:34 -0800 (PST) (envelope-from sgk) Date: Thu, 31 Dec 2015 16:13:00 -0000 From: Steve Kargl To: Gerald Pfeifer Cc: "H.J. Lu" , Paul Richard Thomas , fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: Re: [PATCH] (Partial) Implementation of simplificaiton of CSHIFT Message-ID: <20151231161334.GA11994@troutmask.apl.washington.edu> References: <20151120005836.GA53763@troutmask.apl.washington.edu> <20151120200947.GA61350@troutmask.apl.washington.edu> <20151121162657.GA23304@troutmask.apl.washington.edu> <20151121182014.GA23753@troutmask.apl.washington.edu> <20151121192622.GA81197@troutmask.apl.washington.edu> <20151121200735.GA55464@troutmask.apl.washington.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-SW-Source: 2015-12/txt/msg02237.txt.bz2 On Thu, Dec 31, 2015 at 09:57:10PM +0800, Gerald Pfeifer wrote: > On Sat, 21 Nov 2015, Steve Kargl wrote: > > 2015-11-21 Steven G. Kargl > > > > * simplify.c (gfc_simplify_cshift): Work around bootstrap issues > > due to inappropriate warning options. > > > Index: simplify.c > > =================================================================== > > + /* GCC bootstrap is too stupid to realize that the above code for dm > > + is correct. First, dim can be specified for a rank 1 array. It is > > + not needed in this nor used here. Second, the code is simply waiting > > + for someone to implement rank > 1 simplification. For now, add a > > + pessimization to the code that has a zero valid reason to be here. */ > > + if (dm > array->rank) > > + gcc_unreachable (); > > I'm not sure this comment is appropriate as is. At a minimum, it > should list the version of GCC this was introduced for/with. So, > something like > I have no intention to change the comment. -- Steve