From: Marek Polacek <polacek@redhat.com>
To: Bernd Schmidt <bschmidt@redhat.com>
Cc: Joseph Myers <joseph@codesourcery.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: C PATCH to rectify warning for character types (PR c/23087)
Date: Fri, 08 Jan 2016 18:07:00 -0000 [thread overview]
Message-ID: <20160108180704.GM31604@redhat.com> (raw)
In-Reply-To: <568FF7D8.60004@redhat.com>
On Fri, Jan 08, 2016 at 06:54:32PM +0100, Bernd Schmidt wrote:
> On 01/07/2016 10:19 PM, Joseph Myers wrote:
>
> >I don't think it's desirable to raise the warning for this case under
> >different conditions from the warning for other signedness cases. The
> >targets do differ in signedness - it's just that the difference is between
> >"plain" and "signed" or "plain" and "unsigned", not between signed and
> >unsigned. Maybe the warning message should be more specific in this case,
> >but not a less-specific "incompatible" which is what this patch would
> >achieve.
>
> I was going to voice the same opinion yesterday but forgot to hit Send. If
> you consider signedness of char a tri-state, then there's nothing wrong with
> the warning message.
Well, it's been discussed at length in
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=23087
It seems sort of weird to me to say that 'char' and 'signed char' do differ in
signedness when I know that my machine uses signed chars by default. But I'm
wary of raising the warning -- it's likely to cause more uproar. At this point
I don't know if I actually want to pursue this further, likely not. Yet I'd
like to resolve this very old PR one way or another.
Marek
prev parent reply other threads:[~2016-01-08 18:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 17:11 Marek Polacek
2016-01-07 21:19 ` Joseph Myers
2016-01-08 17:49 ` Martin Sebor
2016-01-08 22:27 ` Joseph Myers
2016-01-08 23:28 ` Martin Sebor
2016-01-08 23:51 ` Joseph Myers
2016-01-09 1:21 ` Martin Sebor
2016-01-11 16:37 ` Martin Sebor
2016-01-08 17:54 ` Bernd Schmidt
2016-01-08 18:07 ` Marek Polacek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160108180704.GM31604@redhat.com \
--to=polacek@redhat.com \
--cc=bschmidt@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=joseph@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).