From: Martin Jambor <mjambor@suse.cz>
To: gcc-patches@gcc.gnu.org
Subject: Re: [hsa merge 07/10] IPA-HSA pass
Date: Fri, 15 Jan 2016 14:53:00 -0000 [thread overview]
Message-ID: <20160115145323.GL3982@virgil.suse.cz> (raw)
In-Reply-To: <20160114125858.GE3017@tucnak.redhat.com>
On Thu, Jan 14, 2016 at 01:58:58PM +0100, Jakub Jelinek wrote:
> Otherwise LGTM.
>
> Jakub
Thanks Jakub, I have committed the following patch from Martin Liska
that addresses your comments.
Martin
2016-01-15 Martin Liska <mliska@suse.cz>
* ipa-hsa.c (process_hsa_functions): Fixed coding style.
(ipa_hsa_read_section): Likewise.
(ipa_hsa_read_section): Likewise.
(pass_ipa_hsa::gate): Removed in_lto_p from the condition.
---
gcc/ipa-hsa.c | 22 ++++++++++++----------
1 file changed, 12 insertions(+), 10 deletions(-)
diff --git a/gcc/ipa-hsa.c b/gcc/ipa-hsa.c
index dd47995..769657f 100644
--- a/gcc/ipa-hsa.c
+++ b/gcc/ipa-hsa.c
@@ -86,8 +86,9 @@ process_hsa_functions (void)
{
if (!check_warn_node_versionable (node))
continue;
- cgraph_node *clone = node->create_virtual_clone
- (vec <cgraph_edge *> (), NULL, NULL, "hsa");
+ cgraph_node *clone
+ = node->create_virtual_clone (vec <cgraph_edge *> (),
+ NULL, NULL, "hsa");
TREE_PUBLIC (clone->decl) = TREE_PUBLIC (node->decl);
clone->force_output = true;
@@ -102,8 +103,9 @@ process_hsa_functions (void)
{
if (!check_warn_node_versionable (node))
continue;
- cgraph_node *clone = node->create_virtual_clone
- (vec <cgraph_edge *> (), NULL, NULL, "hsa");
+ cgraph_node *clone
+ = node->create_virtual_clone (vec <cgraph_edge *> (),
+ NULL, NULL, "hsa");
TREE_PUBLIC (clone->decl) = TREE_PUBLIC (node->decl);
if (!cgraph_local_p (node))
@@ -209,8 +211,8 @@ static void
ipa_hsa_read_section (struct lto_file_decl_data *file_data, const char *data,
size_t len)
{
- const struct lto_function_header *header =
- (const struct lto_function_header *) data;
+ const struct lto_function_header *header
+ = (const struct lto_function_header *) data;
const int cfg_offset = sizeof (struct lto_function_header);
const int main_offset = cfg_offset + header->cfg_size;
const int string_offset = main_offset + header->main_size;
@@ -221,9 +223,9 @@ ipa_hsa_read_section (struct lto_file_decl_data *file_data, const char *data,
lto_input_block ib_main ((const char *) data + main_offset,
header->main_size, file_data->mode_table);
- data_in =
- lto_data_in_create (file_data, (const char *) data + string_offset,
- header->string_size, vNULL);
+ data_in
+ = lto_data_in_create (file_data, (const char *) data + string_offset,
+ header->string_size, vNULL);
count = streamer_read_uhwi (&ib_main);
for (i = 0; i < count; i++)
@@ -317,7 +319,7 @@ public:
bool
pass_ipa_hsa::gate (function *)
{
- return hsa_gen_requested_p () || in_lto_p;
+ return hsa_gen_requested_p ();
}
} // anon namespace
--
2.6.4
next prev parent reply other threads:[~2016-01-15 14:53 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-13 17:55 [hsa merge 00/10] Merge of HSA branch Martin Jambor
2016-01-13 17:55 ` [hsa merge 01/10] Configury changes and new options Martin Jambor
2016-01-14 12:35 ` Jakub Jelinek
2016-02-02 12:53 ` Thomas Schwinge
2016-01-13 17:55 ` [hsa merge 10/10] HSA register allocator Martin Jambor
2016-01-14 14:41 ` Jakub Jelinek
2016-01-15 15:09 ` Martin Jambor
2016-01-13 17:55 ` [hsa merge 04/10] Avoid extraneous remapping in copy_gimple_seq_and_replace_locals Martin Jambor
2016-01-13 18:02 ` Jakub Jelinek
2016-01-13 17:55 ` [hsa merge 02/10] Modifications to libgomp proper Martin Jambor
2016-01-20 13:37 ` Ilya Verbin
2016-01-20 14:48 ` Ilya Verbin
2016-01-20 14:55 ` Jakub Jelinek
2016-01-13 17:55 ` [hsa merge 07/10] IPA-HSA pass Martin Jambor
2016-01-14 12:59 ` Jakub Jelinek
2016-01-15 11:48 ` Martin Liška
2016-01-15 14:53 ` Martin Jambor [this message]
2016-01-15 15:01 ` Jakub Jelinek
2016-01-15 16:02 ` Martin Jambor
2016-01-15 16:10 ` Jakub Jelinek
2016-01-15 16:38 ` Ilya Verbin
2016-01-15 16:45 ` Jakub Jelinek
2016-01-15 18:06 ` Ilya Verbin
2016-01-20 18:54 ` Ilya Verbin
2016-01-21 11:39 ` Alexander Monakov
2016-01-22 10:19 ` Jakub Jelinek
2016-01-28 11:36 ` Partial Offloading (was: [hsa merge 07/10] IPA-HSA pass) Thomas Schwinge
2016-02-17 16:41 ` Ilya Verbin
2016-01-15 19:19 ` [hsa merge 07/10] IPA-HSA pass Alexander Monakov
2016-01-15 19:32 ` Jakub Jelinek
2016-01-15 19:46 ` Alexander Monakov
2016-01-15 19:55 ` Jakub Jelinek
2016-01-15 9:52 ` Jan Hubicka
2016-01-15 11:47 ` Martin Liška
2016-01-16 10:00 ` Jan Hubicka
2016-01-25 15:22 ` Martin Liška
2016-01-25 15:24 ` Jakub Jelinek
2016-01-25 23:41 ` Jan Hubicka
2016-01-27 12:38 ` Martin Liška
2016-01-13 17:55 ` [hsa merge 03/10] HSA libgomp plugin Martin Jambor
2016-01-14 12:37 ` Jakub Jelinek
2016-01-13 17:55 ` [hsa merge 06/10] Pass manager changes Martin Jambor
2016-01-14 12:52 ` Jakub Jelinek
2016-01-13 18:11 ` [hsa merge 09/10] Majority of the HSA back-end Martin Jambor
2016-01-14 14:05 ` Jakub Jelinek
2016-01-15 15:08 ` Martin Jambor
2016-01-15 15:18 ` Jakub Jelinek
2016-01-15 23:49 ` Martin Jambor
2016-01-16 8:58 ` Jakub Jelinek
2016-01-16 9:23 ` Jakub Jelinek
2016-01-18 15:33 ` Martin Jambor
2016-01-18 15:48 ` Jakub Jelinek
2016-01-13 18:12 ` [hsa merge 08/10] HSAIL BRIG description header file Martin Jambor
2016-01-14 13:04 ` Jakub Jelinek
2016-01-15 1:19 ` Ian Lance Taylor
2016-01-15 10:03 ` Richard Biener
2016-01-15 10:14 ` Martin Jambor
2016-01-15 10:17 ` Richard Biener
2016-01-15 10:37 ` Jakub Jelinek
2016-01-15 12:03 ` Jakub Jelinek
2016-01-15 17:23 ` Martin Jambor
2016-01-16 11:43 ` Jakub Jelinek
2016-01-18 15:22 ` Martin Jambor
2016-01-15 17:53 ` Mike Stump
2016-01-15 20:23 ` Richard Biener
2016-02-26 18:58 ` Martin Jambor
2016-02-26 19:28 ` Mike Stump
2016-01-13 18:17 ` [hsa merge 05/10] OpenMP lowering/expansion changes (gridification) Martin Jambor
2016-01-14 12:52 ` Jakub Jelinek
2016-01-15 14:52 ` Martin Jambor
2016-01-14 14:22 ` Alexander Monakov
2016-01-19 10:45 ` [hsa merge 00/10] Merge of HSA branch Martin Jambor
2016-01-19 14:25 ` Richard Biener
2016-01-21 23:10 ` Gerald Pfeifer
2016-01-27 14:20 ` Martin Jambor
2016-01-28 15:18 ` Gerald Pfeifer
2016-02-02 14:20 ` Martin Jambor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160115145323.GL3982@virgil.suse.cz \
--to=mjambor@suse.cz \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).