Re: [hsa merge 10/10] HSA register allocator

[Martin Jambor <mjambor@suse.cz>]

Hi,

On Thu, Jan 14, 2016 at 03:41:34PM +0100, Jakub Jelinek wrote:
> On Wed, Jan 13, 2016 at 06:39:35PM +0100, Martin Jambor wrote:
> > +    for (phi = hbb->m_first_phi;
> > +	 phi;
> > +	 phi = phi->m_next ? as_a <hsa_insn_phi *> (phi->m_next): NULL)
> 
> Space before :
> 
> Ok with that change.
> 

I have committed the following patch from Martin to address this and a
few other code style issues.

Thanks,

Martin

2016-01-15  Martin Liska  <mliska@suse.cz>

	* hsa-regalloc.c (naive_outof_ssa): Fixed coding style.
	(linear_scan_regalloc): Likewise.
	(regalloc): Likewise.
---
 gcc/hsa-regalloc.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/gcc/hsa-regalloc.c b/gcc/hsa-regalloc.c
index 5a42beb..f8e83ecf 100644
--- a/gcc/hsa-regalloc.c
+++ b/gcc/hsa-regalloc.c
@@ -90,7 +90,7 @@ naive_outof_ssa (void)
 
     for (phi = hbb->m_first_phi;
 	 phi;
-	 phi = phi->m_next ? as_a <hsa_insn_phi *> (phi->m_next): NULL)
+	 phi = phi->m_next ? as_a <hsa_insn_phi *> (phi->m_next) : NULL)
       naive_process_phi (phi);
 
     /* Zap PHI nodes, they will be deallocated when everything else will.  */
@@ -525,7 +525,7 @@ linear_scan_regalloc (struct m_reg_class_desc *classes)
       else
 	after_end_number = insn_order;
       /* Everything live-out in this BB has at least an end point
-         after us. */
+	 after us.  */
       EXECUTE_IF_SET_IN_BITMAP (hbb->m_liveout, 0, bit, bi)
 	note_lr_end (ind2reg[bit], after_end_number);
 
@@ -549,7 +549,7 @@ linear_scan_regalloc (struct m_reg_class_desc *classes)
 	}
 
       /* Everything live-in in this BB has a start point before
-         our first insn.  */
+	 our first insn.  */
       int before_start_number;
       if (hbb->m_first_insn)
 	before_start_number = hbb->m_first_insn->m_number;
@@ -570,7 +570,7 @@ linear_scan_regalloc (struct m_reg_class_desc *classes)
 	   are defined at the start of the routine (prologue).  */
 	if (ind2reg[i]->m_lr_begin == insn_order)
 	  ind2reg[i]->m_lr_begin = 0;
-	/* All regs that have no use but a def will have lr_end == 0, 
+	/* All regs that have no use but a def will have lr_end == 0,
 	   they are actually live from def until after the insn they are
 	   defined in.  */
 	if (ind2reg[i]->m_lr_end == 0)
@@ -672,7 +672,7 @@ regalloc (void)
   basic_block bb;
   m_reg_class_desc classes[4];
 
-  /* If there are no registers used in the function, exit right away. */
+  /* If there are no registers used in the function, exit right away.  */
   if (hsa_cfun->m_reg_count == 0)
     return;
 
-- 
2.6.4