From: Jakub Jelinek <jakub@redhat.com>
To: Arnaud Charlet <charlet@adacore.com>
Cc: gcc-patches@gcc.gnu.org
Subject: [PATCH] Another warning fix in adaint.c
Date: Sun, 17 Jan 2016 17:51:00 -0000 [thread overview]
Message-ID: <20160117175125.GO3017@tucnak.redhat.com> (raw)
In-Reply-To: <20160115200939.GA18406@adacore.com>
Hi!
Following patch fixes another warning in adaint.c:
../../gcc/ada/adaint.c: In function 'void __gnat_killprocesstree(int, int)':
../../gcc/ada/adaint.c:3284:26: warning: suggest parentheses around assignment used as truth value [-Wparentheses]
while (d = readdir (dir))
^
Bootstrapped/regtested on x86_64-linux, ok for trunk?
2016-01-17 Jakub Jelinek <jakub@redhat.com>
* adaint.c (__gnat_killprocesstree): Avoid -Wparentheses warning.
--- gcc/ada/adaint.c.jj 2016-01-15 21:15:09.000000000 +0100
+++ gcc/ada/adaint.c 2016-01-16 10:32:44.133293832 +0100
@@ -3281,7 +3281,7 @@ void __gnat_killprocesstree (int pid, in
/* kill child processes first */
- while (d = readdir (dir))
+ while ((d = readdir (dir)) != NULL)
{
if ((d->d_type & DT_DIR) == DT_DIR)
{
Jakub
next prev parent reply other threads:[~2016-01-17 17:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 20:04 [PATCH] Fix warning " Jakub Jelinek
2016-01-15 20:09 ` Arnaud Charlet
2016-01-17 17:51 ` Jakub Jelinek [this message]
2016-01-17 17:56 ` [PATCH] Another warning fix " Arnaud Charlet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160117175125.GO3017@tucnak.redhat.com \
--to=jakub@redhat.com \
--cc=charlet@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).