From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 87490 invoked by alias); 20 Jan 2016 14:01:33 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 87478 invoked by uid 89); 20 Jan 2016 14:01:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.8 required=5.0 tests=BAYES_50,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=sk:DECL_FU, sk:decl_fu, sk:attribu, asm_out_file X-HELO: e06smtp11.uk.ibm.com Received: from e06smtp11.uk.ibm.com (HELO e06smtp11.uk.ibm.com) (195.75.94.107) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Wed, 20 Jan 2016 14:01:32 +0000 Received: from localhost by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 20 Jan 2016 14:01:29 -0000 Received: from d06dlp02.portsmouth.uk.ibm.com (9.149.20.14) by e06smtp11.uk.ibm.com (192.168.101.141) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 20 Jan 2016 14:01:27 -0000 X-IBM-Helo: d06dlp02.portsmouth.uk.ibm.com X-IBM-MailFrom: vogt@linux.vnet.ibm.com X-IBM-RcptTo: gcc-patches@gcc.gnu.org Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id D51C32190068 for ; Wed, 20 Jan 2016 14:01:14 +0000 (GMT) Received: from d06av05.portsmouth.uk.ibm.com (d06av05.portsmouth.uk.ibm.com [9.149.37.229]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u0KE1QDw62193902 for ; Wed, 20 Jan 2016 14:01:26 GMT Received: from d06av05.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av05.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u0KE1Qrv007346 for ; Wed, 20 Jan 2016 07:01:26 -0700 Received: from bl3ahm9f.de.ibm.com (sig-9-81-64-103.evts.uk.ibm.com [9.81.64.103]) by d06av05.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id u0KE1Q1G007319 for ; Wed, 20 Jan 2016 07:01:26 -0700 Received: from dvogt by bl3ahm9f.de.ibm.com with local (Exim 4.76) (envelope-from ) id 1aLtK8-0008CF-Py; Wed, 20 Jan 2016 15:01:24 +0100 Date: Wed, 20 Jan 2016 14:01:00 -0000 From: Dominik Vogt To: gcc-patches@gcc.gnu.org Subject: Re: [PATCH 2/5] s390: Fix missing .size directives. Message-ID: <20160120140124.GA30402@linux.vnet.ibm.com> Reply-To: vogt@linux.vnet.ibm.com Mail-Followup-To: vogt@linux.vnet.ibm.com, gcc-patches@gcc.gnu.org References: <1451762204-13364-1-git-send-email-koriakin@0x04.net> <1451762204-13364-3-git-send-email-koriakin@0x04.net> <569F88A7.1020000@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <569F88A7.1020000@linux.vnet.ibm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16012014-0041-0000-0000-0000073AEB25 X-SW-Source: 2016-01/txt/msg01521.txt.bz2 On Wed, Jan 20, 2016 at 02:16:23PM +0100, Andreas Krebbel wrote: > On 01/02/2016 08:16 PM, Marcin Kościelnicki wrote: > > s390_asm_declare_function_size (FILE *asm_out_file, > > - const char *fnname ATTRIBUTE_UNUSED, tree decl) > > + const char *fnname, tree decl) > > { > > + if (!flag_inhibit_size_directive) > > + ASM_OUTPUT_MEASURED_SIZE (asm_out_file, fnname); > > if (DECL_FUNCTION_SPECIFIC_TARGET (decl) == NULL) > > return; > > fprintf (asm_out_file, "\t.machine pop\n"); > > It would be good to use the original ASM_DECLARE_FUNCTION_SIZE macro from config/elfos.h here. This > probably would require to change its name in s390.h first and then use it from > s390_asm_declare_function_size. Not really beautiful but at least changes to the original macro > would not require adjusting our backend. Maybe it's better not to invent yet another solution to deal with this and just do it like proposed in the patch. So if the default implementation is ever changed, the same search pattern will find all identical copies of the code. Ciao Dominik ^_^ ^_^ -- Dominik Vogt IBM Germany