From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 36100 invoked by alias); 20 Jan 2016 14:55:58 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 36081 invoked by uid 89); 20 Jan 2016 14:55:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=59pm, 59PM, team X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 20 Jan 2016 14:55:55 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 50E67C0ED3E1; Wed, 20 Jan 2016 14:55:54 +0000 (UTC) Received: from tucnak.zalov.cz ([10.3.113.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u0KEtqSp017440 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 20 Jan 2016 09:55:53 -0500 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id u0KEtnKV021099; Wed, 20 Jan 2016 15:55:50 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id u0KEtmFu021098; Wed, 20 Jan 2016 15:55:48 +0100 Date: Wed, 20 Jan 2016 14:55:00 -0000 From: Jakub Jelinek To: Ilya Verbin Cc: Martin Jambor , GCC Patches Subject: Re: [hsa merge 02/10] Modifications to libgomp proper Message-ID: <20160120145548.GA3017@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <20160113173925.220029649@virgil.suse.cz> <20160113173925.431228371@virgil.suse.cz> <20160120144759.GB49431@msticlxl57.ims.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160120144759.GB49431@msticlxl57.ims.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-IsSubscribed: yes X-SW-Source: 2016-01/txt/msg01534.txt.bz2 On Wed, Jan 20, 2016 at 05:47:59PM +0300, Ilya Verbin wrote: > OK for trunk? > > libgomp/ > * task.c (gomp_create_target_task): Set firstprivate_copies to NULL. > > diff --git a/libgomp/task.c b/libgomp/task.c > index 0f45c44..38d4e9b 100644 > --- a/libgomp/task.c > +++ b/libgomp/task.c > @@ -683,6 +683,7 @@ gomp_create_target_task (struct gomp_device_descr *devicep, > ttask->state = state; > ttask->task = task; > ttask->team = team; > + ttask->firstprivate_copies = NULL; > task->fn = NULL; > task->fn_data = ttask; > task->final_task = 0; Ok (though, eventually I'd prefer if free (ttask->firstprivate_copies) is only performed for the shared mem async tasks and not other one. Jakub