From: Jakub Jelinek <jakub@redhat.com>
To: "Martin Liška" <mliska@suse.cz>
Cc: gcc-patches@gcc.gnu.org,
Richard Biener <richard.guenther@gmail.com>,
Jan Hubicka <hubicka@ucw.cz>,
Martin Jambor <mjambor@suse.cz>
Subject: Re: [hsa merge 07/10] IPA-HSA pass
Date: Mon, 25 Jan 2016 15:24:00 -0000 [thread overview]
Message-ID: <20160125152405.GL3017@tucnak.redhat.com> (raw)
In-Reply-To: <56A63D8E.4070907@suse.cz>
On Mon, Jan 25, 2016 at 04:21:50PM +0100, Martin Liška wrote:
> On 01/16/2016 11:00 AM, Jan Hubicka wrote:
> > Can't it be represented via explicit REF_ADDR or something like that?
> >
> > Honza
>
> Hi.
>
> Sure, I've just done a patch that can do that. However, as we're currently in stage4,
> that change would probably require explicit permission of a release manager?
If Honza is fine with it and you've tested it, this is ok for trunk.
> >From 9639fff94d043c55b55bfb12bb086032db565f0a Mon Sep 17 00:00:00 2001
> From: marxin <mliska@suse.cz>
> Date: Mon, 25 Jan 2016 16:11:00 +0100
> Subject: [PATCH] HSA: simplify partitioning of HSA kernels and host impls.
>
> gcc/lto/ChangeLog:
>
> 2016-01-25 Martin Liska <mliska@suse.cz>
>
> * lto-partition.c (add_symbol_to_partition_1): Remove usage
> of hsa_summaries.
>
> gcc/ChangeLog:
>
> 2016-01-25 Martin Liska <mliska@suse.cz>
>
> * hsa.c (hsa_summary_t::link_functions): Create IPA_REF_ADDR
> reference for an HSA kernel and its host function.
> ---
> gcc/hsa.c | 5 +++++
> gcc/lto/lto-partition.c | 19 -------------------
> 2 files changed, 5 insertions(+), 19 deletions(-)
>
> diff --git a/gcc/hsa.c b/gcc/hsa.c
> index ec23f81..f0b3205 100644
> --- a/gcc/hsa.c
> +++ b/gcc/hsa.c
> @@ -781,6 +781,11 @@ hsa_summary_t::link_functions (cgraph_node *gpu, cgraph_node *host,
> TREE_OPTIMIZATION (fn_opts)->x_flag_tree_loop_vectorize = false;
> TREE_OPTIMIZATION (fn_opts)->x_flag_tree_slp_vectorize = false;
> DECL_FUNCTION_SPECIFIC_OPTIMIZATION (gdecl) = fn_opts;
> +
> + /* Create reference between a kernel and a corresponding host implementation
> + to quarantee LTO streaming to a same LTRANS. */
> + if (kind == HSA_KERNEL)
> + gpu->create_reference (host, IPA_REF_ADDR);
> }
>
> /* Add a HOST function to HSA summaries. */
> diff --git a/gcc/lto/lto-partition.c b/gcc/lto/lto-partition.c
> index eb28fed..9eb63c2 100644
> --- a/gcc/lto/lto-partition.c
> +++ b/gcc/lto/lto-partition.c
> @@ -34,7 +34,6 @@ along with GCC; see the file COPYING3. If not see
> #include "ipa-prop.h"
> #include "ipa-inline.h"
> #include "lto-partition.h"
> -#include "hsa.h"
>
> vec<ltrans_partition> ltrans_partitions;
>
> @@ -171,24 +170,6 @@ add_symbol_to_partition_1 (ltrans_partition part, symtab_node *node)
> Therefore put it into the same partition. */
> if (cnode->instrumented_version)
> add_symbol_to_partition_1 (part, cnode->instrumented_version);
> -
> - /* Add an HSA associated with the symbol. */
> - if (hsa_summaries != NULL)
> - {
> - hsa_function_summary *s = hsa_summaries->get (cnode);
> - if (s->m_kind == HSA_KERNEL)
> - {
> - /* Add binded function. */
> - bool added = add_symbol_to_partition_1 (part,
> - s->m_binded_function);
> - gcc_assert (added);
> - if (symtab->dump_file)
> - fprintf (symtab->dump_file,
> - "adding an HSA function (host/gpu) to the "
> - "partition: %s\n",
> - s->m_binded_function->name ());
> - }
> - }
> }
>
> add_references_to_partition (part, node);
> --
> 2.7.0
>
Jakub
next prev parent reply other threads:[~2016-01-25 15:24 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-13 17:55 [hsa merge 00/10] Merge of HSA branch Martin Jambor
2016-01-13 17:55 ` [hsa merge 06/10] Pass manager changes Martin Jambor
2016-01-14 12:52 ` Jakub Jelinek
2016-01-13 17:55 ` [hsa merge 03/10] HSA libgomp plugin Martin Jambor
2016-01-14 12:37 ` Jakub Jelinek
2016-01-13 17:55 ` [hsa merge 02/10] Modifications to libgomp proper Martin Jambor
2016-01-20 13:37 ` Ilya Verbin
2016-01-20 14:48 ` Ilya Verbin
2016-01-20 14:55 ` Jakub Jelinek
2016-01-13 17:55 ` [hsa merge 07/10] IPA-HSA pass Martin Jambor
2016-01-14 12:59 ` Jakub Jelinek
2016-01-15 11:48 ` Martin Liška
2016-01-15 14:53 ` Martin Jambor
2016-01-15 15:01 ` Jakub Jelinek
2016-01-15 16:02 ` Martin Jambor
2016-01-15 16:10 ` Jakub Jelinek
2016-01-15 16:38 ` Ilya Verbin
2016-01-15 16:45 ` Jakub Jelinek
2016-01-15 18:06 ` Ilya Verbin
2016-01-20 18:54 ` Ilya Verbin
2016-01-21 11:39 ` Alexander Monakov
2016-01-22 10:19 ` Jakub Jelinek
2016-01-28 11:36 ` Partial Offloading (was: [hsa merge 07/10] IPA-HSA pass) Thomas Schwinge
2016-02-17 16:41 ` Ilya Verbin
2016-01-15 19:19 ` [hsa merge 07/10] IPA-HSA pass Alexander Monakov
2016-01-15 19:32 ` Jakub Jelinek
2016-01-15 19:46 ` Alexander Monakov
2016-01-15 19:55 ` Jakub Jelinek
2016-01-15 9:52 ` Jan Hubicka
2016-01-15 11:47 ` Martin Liška
2016-01-16 10:00 ` Jan Hubicka
2016-01-25 15:22 ` Martin Liška
2016-01-25 15:24 ` Jakub Jelinek [this message]
2016-01-25 23:41 ` Jan Hubicka
2016-01-27 12:38 ` Martin Liška
2016-01-13 17:55 ` [hsa merge 10/10] HSA register allocator Martin Jambor
2016-01-14 14:41 ` Jakub Jelinek
2016-01-15 15:09 ` Martin Jambor
2016-01-13 17:55 ` [hsa merge 04/10] Avoid extraneous remapping in copy_gimple_seq_and_replace_locals Martin Jambor
2016-01-13 18:02 ` Jakub Jelinek
2016-01-13 17:55 ` [hsa merge 01/10] Configury changes and new options Martin Jambor
2016-01-14 12:35 ` Jakub Jelinek
2016-02-02 12:53 ` Thomas Schwinge
2016-01-13 18:11 ` [hsa merge 09/10] Majority of the HSA back-end Martin Jambor
2016-01-14 14:05 ` Jakub Jelinek
2016-01-15 15:08 ` Martin Jambor
2016-01-15 15:18 ` Jakub Jelinek
2016-01-15 23:49 ` Martin Jambor
2016-01-16 8:58 ` Jakub Jelinek
2016-01-16 9:23 ` Jakub Jelinek
2016-01-18 15:33 ` Martin Jambor
2016-01-18 15:48 ` Jakub Jelinek
2016-01-13 18:12 ` [hsa merge 08/10] HSAIL BRIG description header file Martin Jambor
2016-01-14 13:04 ` Jakub Jelinek
2016-01-15 1:19 ` Ian Lance Taylor
2016-01-15 10:03 ` Richard Biener
2016-01-15 10:14 ` Martin Jambor
2016-01-15 10:17 ` Richard Biener
2016-01-15 10:37 ` Jakub Jelinek
2016-01-15 12:03 ` Jakub Jelinek
2016-01-15 17:23 ` Martin Jambor
2016-01-16 11:43 ` Jakub Jelinek
2016-01-18 15:22 ` Martin Jambor
2016-01-15 17:53 ` Mike Stump
2016-01-15 20:23 ` Richard Biener
2016-02-26 18:58 ` Martin Jambor
2016-02-26 19:28 ` Mike Stump
2016-01-13 18:17 ` [hsa merge 05/10] OpenMP lowering/expansion changes (gridification) Martin Jambor
2016-01-14 12:52 ` Jakub Jelinek
2016-01-15 14:52 ` Martin Jambor
2016-01-14 14:22 ` Alexander Monakov
2016-01-19 10:45 ` [hsa merge 00/10] Merge of HSA branch Martin Jambor
2016-01-19 14:25 ` Richard Biener
2016-01-21 23:10 ` Gerald Pfeifer
2016-01-27 14:20 ` Martin Jambor
2016-01-28 15:18 ` Gerald Pfeifer
2016-02-02 14:20 ` Martin Jambor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160125152405.GL3017@tucnak.redhat.com \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
--cc=mjambor@suse.cz \
--cc=mliska@suse.cz \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).