[wwwdocs] gcc-6/changes.html: diagnostics, Levenshtein, -Wmisleading-indentation, jit

[wwwdocs] gcc-6/changes.html: diagnostics, Levenshtein, -Wmisleading-indentation, jit

[David Malcolm]

[-- Attachment #1: Type: text/plain, Size: 418 bytes --]

The attached patch adds information on various things to the
gcc-6/changes.html page:

* source-range-tracking (the patch merges the description of the string
location work into this, and updates the colorization of the example to
reflect gcc-6's behavior)
* fix-it hints
* hints for misspelled member names
* -Wmisleading-indentation
* jit improvements
* hints for misspelled command-line options

OK to commit?
Dave

[-- Attachment #2: various-gcc-6-changes.patch --]
[-- Type: text/x-patch, Size: 6204 bytes --]

Index: htdocs/gcc-6/changes.html
===================================================================
RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-6/changes.html,v
retrieving revision 1.46
diff -u -p -r1.46 changes.html
--- htdocs/gcc-6/changes.html	22 Dec 2015 19:23:31 -0000	1.46
+++ htdocs/gcc-6/changes.html	6 Jan 2016 14:41:45 -0000
@@ -63,13 +63,40 @@ enum {
   oldval __attribute__ ((deprecated ("too old")))
 };
 </pre></blockquote></li>
-<li>Initial support for precise diagnostic locations within strings:
+<li>Source locations for the C and C++ compilers are now tracked as ranges,
+  rather than just points, making it easier to identify the subexpression
+  of interest within a complicated expression.
+  For example:
 <blockquote><pre>
-<b>format-strings.c:3:14:</b> <b style='color:magenta'>warning:</b> field width specifier <b>'*'</b> expects a matching <b>'int'</b> argument [-Wformat=]
+<b>test.cc:</b> In function <b>'int test(int, int, foo, int, int)'</b>:
+<b>test.cc:5:16:</b> <b style='color:red'>error:</b> no match for <b>'operator*'</b> (operand types are <b>'int'</b> and <b>'foo'</b>)
+   return p + <b style='color:red'>q * r</b> * s + t;
+              <b style='color:red'>~~^~~</b>
+</pre></blockquote>
+In addition, there is now initial support for precise diagnostic locations
+within strings:
+<blockquote><pre>
+<b>format-strings.c:3:14:</b> <b style='color:magenta'>warning:</b> field width specifier <b>'*'</b> expects a matching <b>'int'</b> argument [<b style='color:magenta'>-Wformat=</b>]
    printf("%*d");
-            <b style='color:lime'>^</b>
+            <b style='color:magenta'>^</b>
 </pre></blockquote></li>
-
+    <li>Diagnostics can now contain "fix-it hints", which are displayed
+      in context underneath the relevant source code.  For example:
+      <!-- this is currently the only example in the tree; various others are pending  -->
+<blockquote><pre>
+<b>fixits.c:</b> In function <b>'bad_deref'</b>:
+<b>fixits.c:11:13:</b> <b style='color:red'>error:</b> <b>'ptr'</b> is a pointer; did you mean to use <b>'->'</b>?
+   return ptr<b style='color:red'>.</b>x;
+             <b style='color:red'>^</b>
+             <b style='color:red'>-></b>
+</pre></blockquote></li>
+    <li>The C and C++ compilers now offer suggestions for misspelled field names:
+<blockquote><pre>
+<b>spellcheck-fields.cc:52:13:</b> <b style='color:red'>error:</b> <b>'struct s'</b> has no member named <b>'colour'</b>; did you mean <b>'color'</b>?
+   return ptr-&gt;<b style='color:red'>colour</b>;
+               <b style='color:red'>^~~~~~</b>
+</pre></blockquote></li>
+    <!-- also, pending patch to add fix-it hints to the above -->
     <li>New command-line options have been added for the C and C++ compilers:
       <ul>
         <li><code>-Wshift-negative-value</code> warns about left shifting a
@@ -89,8 +116,29 @@ enum {
           depends on the optimization options used.</li>
         <li><code>-Wduplicated-cond</code> warns about duplicated conditions
 	  in an if-else-if chain.</li>
+        <li><code>-Wmisleading-indentation</code> warns about places where the
+          indentation of the code gives a misleading idea of the block
+          structure of the code to a human reader.  For example, given
+          <a href="https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2014-1266">CVE-2014-1266</a>:
+<blockquote><pre>
+<b>sslKeyExchange.c:</b> In function <b>'SSLVerifySignedServerKeyExchange'</b>:
+<b>sslKeyExchange.c:631:8:</b> <b style='color:magenta'>warning:</b> statement is indented as if it were guarded by... [<b style='color:magenta'>-Wmisleading-indentation</b>]
+        <b style='color:magenta'>goto</b> fail;
+        <b style='color:magenta'>^~~~</b>
+<b>sslKeyExchange.c:629:4:</b> <b style='color:cyan'>note:</b> ...this 'if' clause, but it is not
+    <b style='color:cyan'>if</b> ((err = SSLHashSHA1.update(&hashCtx, &signedParams)) != 0)
+    <b style='color:cyan'>^~</b>
+</pre></blockquote>
+          This warning is enabled by <code>-Wall</code>.</li>
       </ul>
     </li>
+    <li>The C and C++ compilers now emit saner error messages if
+      merge-conflict markers are present in a source file.
+<blockquote><pre>
+<b>test.c:3:1:</b> <b style='color:red'>error:</b> version control conflict marker in file
+ <b style='color:red'><<<<<<<</b> HEAD
+ <b style='color:red'>^~~~~~~</b>
+</pre></blockquote></li>
   </ul>
 
 <h3 id="c">C</h3>
@@ -166,8 +214,18 @@ enum {
 
 
 <!-- .................................................................. -->
-<!-- <h2 id="jit">libgccjit</h2> -->
-
+<h2 id="jit">libgccjit</h2>
+  <ul>
+    <li>The driver code is now run in-process within libgccjit,
+      providing a small speed-up of the compilation process.</li>
+    <li>The API has gained entrypoints for
+      <ul>
+        <li><a href="https://gcc.gnu.org/onlinedocs/jit/topics/performance.html">timing how long was spent in different parts of code</a>,</li>
+        <li><a href="https://gcc.gnu.org/onlinedocs/jit/topics/functions.html#gcc_jit_block_end_with_switch">creating switch statements</a>,</li>
+        <li><a href="https://gcc.gnu.org/onlinedocs/jit/topics/contexts.html#gcc_jit_context_set_bool_allow_unreachable_blocks">allowing unreachable basic blocks in a function</a>, and</li>
+        <li><a href="https://gcc.gnu.org/onlinedocs/jit/topics/contexts.html#gcc_jit_context_add_command_line_option">adding arbitrary command-line options to a compilation</a>.</li>
+      </ul>
+  </ul>
 
 <!-- .................................................................. -->
 <h2 id="targets">New Targets and Target Specific Improvements</h2>
@@ -389,6 +447,12 @@ enum {
 <h2>Other significant improvements</h2>
 
   <ul>
+    <li>The <code>gcc</code> and <code>g++</code> driver programs will now
+      provide suggestions for misspelled command line options.
+<blockquote><pre>
+$ gcc -static-libfortran test.f95
+gcc: <b style='color:red'>error:</b> unrecognized command line option <b>'-static-libfortran'</b>; did you mean <b>'-static-libgfortran'</b>?
+</pre></blockquote></li>
     <li>The <code>--enable-default-pie</code> configure option enables
 	generation of PIE by default.</li>
   </ul>

PING Re: [wwwdocs] gcc-6/changes.html: diagnostics, Levenshtein, -Wmisleading-indentation, jit

[David Malcolm]

Ping: https://gcc.gnu.org/ml/gcc-patches/2016-01/msg00250.html

On Wed, 2016-01-06 at 09:50 -0500, David Malcolm wrote:
> The attached patch adds information on various things to the
> gcc-6/changes.html page:
> 
> * source-range-tracking (the patch merges the description of the string
> location work into this, and updates the colorization of the example to
> reflect gcc-6's behavior)
> * fix-it hints
> * hints for misspelled member names
> * -Wmisleading-indentation
> * jit improvements
> * hints for misspelled command-line options
> 
> OK to commit?
> Dave

[wwwdocs] gcc-6/changes.html: diagnostics, Levenshtein, -Wmisleading-indentation, jit (v2)

[David Malcolm]

[-- Attachment #1: Type: text/plain, Size: 856 bytes --]

On Wed, 2016-01-13 at 10:00 -0500, David Malcolm wrote:
> Ping: https://gcc.gnu.org/ml/gcc-patches/2016-01/msg00250.html
> 
> On Wed, 2016-01-06 at 09:50 -0500, David Malcolm wrote:
> > The attached patch adds information on various things to the
> > gcc-6/changes.html page:
> > 
> > * source-range-tracking (the patch merges the description of the string
> > location work into this, and updates the colorization of the example to
> > reflect gcc-6's behavior)
> > * fix-it hints
> > * hints for misspelled member names
> > * -Wmisleading-indentation
> > * jit improvements
> > * hints for misspelled command-line options
> > 
> > OK to commit?
> > Dave

Oops; I forgot to validate it; sorry.

Here's an updated version of the above, which the W3C validator
reports as being clean (fixing various "&" and "<" and a missing
end-tag).

OK to commit?

Dave

[-- Attachment #2: various-gcc6-changes-v2.patch --]
[-- Type: text/x-patch, Size: 6245 bytes --]

Index: htdocs/gcc-6/changes.html
===================================================================
RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-6/changes.html,v
retrieving revision 1.46
diff -u -p -r1.46 changes.html
--- htdocs/gcc-6/changes.html	22 Dec 2015 19:23:31 -0000	1.46
+++ htdocs/gcc-6/changes.html	15 Jan 2016 17:58:36 -0000
@@ -63,13 +63,40 @@ enum {
   oldval __attribute__ ((deprecated ("too old")))
 };
 </pre></blockquote></li>
-<li>Initial support for precise diagnostic locations within strings:
+<li>Source locations for the C and C++ compilers are now tracked as ranges,
+  rather than just points, making it easier to identify the subexpression
+  of interest within a complicated expression.
+  For example:
 <blockquote><pre>
-<b>format-strings.c:3:14:</b> <b style='color:magenta'>warning:</b> field width specifier <b>'*'</b> expects a matching <b>'int'</b> argument [-Wformat=]
+<b>test.cc:</b> In function <b>'int test(int, int, foo, int, int)'</b>:
+<b>test.cc:5:16:</b> <b style='color:red'>error:</b> no match for <b>'operator*'</b> (operand types are <b>'int'</b> and <b>'foo'</b>)
+   return p + <b style='color:red'>q * r</b> * s + t;
+              <b style='color:red'>~~^~~</b>
+</pre></blockquote>
+In addition, there is now initial support for precise diagnostic locations
+within strings:
+<blockquote><pre>
+<b>format-strings.c:3:14:</b> <b style='color:magenta'>warning:</b> field width specifier <b>'*'</b> expects a matching <b>'int'</b> argument [<b style='color:magenta'>-Wformat=</b>]
    printf("%*d");
-            <b style='color:lime'>^</b>
+            <b style='color:magenta'>^</b>
 </pre></blockquote></li>
-
+    <li>Diagnostics can now contain "fix-it hints", which are displayed
+      in context underneath the relevant source code.  For example:
+      <!-- this is currently the only example in the tree; various others are pending  -->
+<blockquote><pre>
+<b>fixits.c:</b> In function <b>'bad_deref'</b>:
+<b>fixits.c:11:13:</b> <b style='color:red'>error:</b> <b>'ptr'</b> is a pointer; did you mean to use <b>'->'</b>?
+   return ptr<b style='color:red'>.</b>x;
+             <b style='color:red'>^</b>
+             <b style='color:red'>-></b>
+</pre></blockquote></li>
+    <li>The C and C++ compilers now offer suggestions for misspelled field names:
+<blockquote><pre>
+<b>spellcheck-fields.cc:52:13:</b> <b style='color:red'>error:</b> <b>'struct s'</b> has no member named <b>'colour'</b>; did you mean <b>'color'</b>?
+   return ptr-&gt;<b style='color:red'>colour</b>;
+               <b style='color:red'>^~~~~~</b>
+</pre></blockquote></li>
+    <!-- also, pending patch to add fix-it hints to the above -->
     <li>New command-line options have been added for the C and C++ compilers:
       <ul>
         <li><code>-Wshift-negative-value</code> warns about left shifting a
@@ -89,8 +116,29 @@ enum {
           depends on the optimization options used.</li>
         <li><code>-Wduplicated-cond</code> warns about duplicated conditions
 	  in an if-else-if chain.</li>
+        <li><code>-Wmisleading-indentation</code> warns about places where the
+          indentation of the code gives a misleading idea of the block
+          structure of the code to a human reader.  For example, given
+          <a href="https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2014-1266">CVE-2014-1266</a>:
+<blockquote><pre>
+<b>sslKeyExchange.c:</b> In function <b>'SSLVerifySignedServerKeyExchange'</b>:
+<b>sslKeyExchange.c:631:8:</b> <b style='color:magenta'>warning:</b> statement is indented as if it were guarded by... [<b style='color:magenta'>-Wmisleading-indentation</b>]
+        <b style='color:magenta'>goto</b> fail;
+        <b style='color:magenta'>^~~~</b>
+<b>sslKeyExchange.c:629:4:</b> <b style='color:cyan'>note:</b> ...this 'if' clause, but it is not
+    <b style='color:cyan'>if</b> ((err = SSLHashSHA1.update(&amp;hashCtx, &amp;signedParams)) != 0)
+    <b style='color:cyan'>^~</b>
+</pre></blockquote>
+          This warning is enabled by <code>-Wall</code>.</li>
       </ul>
     </li>
+    <li>The C and C++ compilers now emit saner error messages if
+      merge-conflict markers are present in a source file.
+<blockquote><pre>
+<b>test.c:3:1:</b> <b style='color:red'>error:</b> version control conflict marker in file
+ <b style='color:red'>&lt;&lt;&lt;&lt;&lt;&lt;&lt;</b> HEAD
+ <b style='color:red'>^~~~~~~</b>
+</pre></blockquote></li>
   </ul>
 
 <h3 id="c">C</h3>
@@ -166,8 +214,19 @@ enum {
 
 
 <!-- .................................................................. -->
-<!-- <h2 id="jit">libgccjit</h2> -->
-
+<h2 id="jit">libgccjit</h2>
+  <ul>
+    <li>The driver code is now run in-process within libgccjit,
+      providing a small speed-up of the compilation process.</li>
+    <li>The API has gained entrypoints for
+      <ul>
+        <li><a href="https://gcc.gnu.org/onlinedocs/jit/topics/performance.html">timing how long was spent in different parts of code</a>,</li>
+        <li><a href="https://gcc.gnu.org/onlinedocs/jit/topics/functions.html#gcc_jit_block_end_with_switch">creating switch statements</a>,</li>
+        <li><a href="https://gcc.gnu.org/onlinedocs/jit/topics/contexts.html#gcc_jit_context_set_bool_allow_unreachable_blocks">allowing unreachable basic blocks in a function</a>, and</li>
+        <li><a href="https://gcc.gnu.org/onlinedocs/jit/topics/contexts.html#gcc_jit_context_add_command_line_option">adding arbitrary command-line options to a compilation</a>.</li>
+      </ul>
+    </li>
+  </ul>
 
 <!-- .................................................................. -->
 <h2 id="targets">New Targets and Target Specific Improvements</h2>
@@ -389,6 +448,12 @@ enum {
 <h2>Other significant improvements</h2>
 
   <ul>
+    <li>The <code>gcc</code> and <code>g++</code> driver programs will now
+      provide suggestions for misspelled command line options.
+<blockquote><pre>
+$ gcc -static-libfortran test.f95
+gcc: <b style='color:red'>error:</b> unrecognized command line option <b>'-static-libfortran'</b>; did you mean <b>'-static-libgfortran'</b>?
+</pre></blockquote></li>
     <li>The <code>--enable-default-pie</code> configure option enables
 	generation of PIE by default.</li>
   </ul>

Re: [wwwdocs] gcc-6/changes.html: diagnostics, Levenshtein, -Wmisleading-indentation, jit (v2)

[Gerald Pfeifer]

On Fri, 15 Jan 2016, David Malcolm wrote:
> Here's an updated version of the above, which the W3C validator
> reports as being clean (fixing various "&" and "<" and a missing
> end-tag).

Nice - and a lot of nice changes you implemented since GCC 5!

> OK to commit?

Yep.  I was going to flag "misspelled" as being misspelt, but
my dictionary tells me you can actually say both. ;-)

Gerald

Re: [wwwdocs] gcc-6/changes.html: diagnostics, Levenshtein, -Wmisleading-indentation, jit (v2)

[Manuel López-Ibáñez]

On 19/01/16 17:08, Gerald Pfeifer wrote:
> On Fri, 15 Jan 2016, David Malcolm wrote:
>> Here's an updated version of the above, which the W3C validator
>> reports as being clean (fixing various "&" and "<" and a missing
>> end-tag).
>
> Nice - and a lot of nice changes you implemented since GCC 5!


Am I the only one who doesn't see the colors at 
https://gcc.gnu.org/gcc-6/changes.html#c-family nor 
https://gcc.gnu.org/gcc-5/changes.html#fortran ?

Firefox 43.0.4 says "Content Security Policy: The page's settings blocked the 
loading of a resource at self ("default-src https://gcc.gnu.org http: https:")."

Cheers,

Manuel.

Re: [wwwdocs] gcc-6/changes.html: diagnostics, Levenshtein, -Wmisleading-indentation, jit (v2)

[Mike Stump]

On Jan 19, 2016, at 11:05 AM, Manuel López-Ibáñez <lopezibanez@gmail.com> wrote:
> 
> Am I the only one who doesn't see the colors at https://gcc.gnu.org/gcc-6/changes.html#c-family nor https://gcc.gnu.org/gcc-5/changes.html#fortran ?

Yes.  The darkslategrey of the headings is very close to black, but the links should be blue.

> Firefox 43.0.4 says "Content Security Policy: The page's settings blocked the loading of a resource at self ("default-src https://gcc.gnu.org http: https:").”

Just hit clear and then reload, and see if it comes back.  Don’t think it will.

Re: [wwwdocs] gcc-6/changes.html: diagnostics, Levenshtein, -Wmisleading-indentation, jit (v2)

[Manuel López-Ibáñez]

On 19 January 2016 at 19:31, Mike Stump <mikestump@comcast.net> wrote:
> On Jan 19, 2016, at 11:05 AM, Manuel López-Ibáñez <lopezibanez@gmail.com> wrote:
>>
>> Am I the only one who doesn't see the colors at https://gcc.gnu.org/gcc-6/changes.html#c-family nor https://gcc.gnu.org/gcc-5/changes.html#fortran ?
>
> Yes.  The darkslategrey of the headings is very close to black, but the links should be blue.

Those colors are fine but the example diagnostics should also have
colors. They had when I added them some months ago.

Re: [wwwdocs] gcc-6/changes.html: diagnostics, Levenshtein, -Wmisleading-indentation, jit (v2)

[Jakub Jelinek]

On Tue, Jan 19, 2016 at 07:42:53PM +0000, Manuel López-Ibáñez wrote:
> On 19 January 2016 at 19:31, Mike Stump <mikestump@comcast.net> wrote:
> > On Jan 19, 2016, at 11:05 AM, Manuel López-Ibáñez <lopezibanez@gmail.com> wrote:
> >>
> >> Am I the only one who doesn't see the colors at https://gcc.gnu.org/gcc-6/changes.html#c-family nor https://gcc.gnu.org/gcc-5/changes.html#fortran ?
> >
> > Yes.  The darkslategrey of the headings is very close to black, but the links should be blue.
> 
> Those colors are fine but the example diagnostics should also have
> colors. They had when I added them some months ago.

Perhaps we need to use something other than <b style='color:magenta'>...</b>
and similar, the question is what.  It certainly worked well back almost 3
years ago when I've added those into gcc-4.9/changes.html.

	Jakub

Re: [wwwdocs] gcc-6/changes.html: diagnostics, Levenshtein, -Wmisleading-indentation, jit (v2)

[Mikhail Maltsev]

On 01/19/2016 10:05 PM, Manuel López-Ibáñez wrote:
> Am I the only one who doesn't see the colors at
> https://gcc.gnu.org/gcc-6/changes.html#c-family nor
> https://gcc.gnu.org/gcc-5/changes.html#fortran ?
> 
> Firefox 43.0.4 says "Content Security Policy: The page's settings blocked the
> loading of a resource at self ("default-src https://gcc.gnu.org http: https:")."

This problem also reproduces with Chrome Version "47.0.2526.106 unknown
(64-bit)". The error message says:

"Refused to apply inline style because it violates the following Content
Security Policy directive: "default-src 'self' http: https:". Either the
'unsafe-inline' keyword, a hash
('sha256-8f935d27GvUutRyY9yWScUMiFUk4WTdZURISiYfPOeQ='), or a nonce
('nonce-...') is required to enable inline execution. Note also that 'style-src'
was not explicitly set, so 'default-src' is used as a fallback."

I think, this can be fixed by replacing 'style="color:red"' with 'class="..."'
and adding the corresponding CSS class to the stylesheet.


-- 
Regards,
    Mikhail Maltsev

Re: [wwwdocs] gcc-6/changes.html: diagnostics, Levenshtein, -Wmisleading-indentation, jit (v2)

[Gerald Pfeifer]

On Tue, 19 Jan 2016, Jakub Jelinek wrote:
> Perhaps we need to use something other than <b style='color:magenta'>...</b>
> and similar, the question is what.  It certainly worked well back almost 3
> years ago when I've added those into gcc-4.9/changes.html.

And interestingly it still does when I download the page and view
it locally (Firefox 43 or Google Chrome).

Instead of hardcoding <b style='color:red'>text</b> it makes sense
to use <span class="boldred">text</span> which is easier (and easier
to tweak, and I just applied the patch below.

Interestingly enough, same result:  Looks just fine when viewed
locally; https://gcc.gnu.org/gcc-6/changes.html in the browser
does not show the color, though it validates. :-(

Hmm.

Gerald 

Index: changes.html
===================================================================
RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-6/changes.html,v
retrieving revision 1.48
diff -u -r1.48 changes.html
--- changes.html	19 Jan 2016 17:48:53 -0000	1.48
+++ changes.html	19 Jan 2016 22:41:22 -0000
@@ -2,6 +2,10 @@
 
 <head>
 <title>GCC 6 Release Series &mdash; Changes, New Features, and Fixes</title>
+
+<style type="text/css">
+  .boldred { font-weight:bold; color:red; }
+</style>
 </head>
 
 <!-- GCC maintainers, please do not hesitate to update/contribute entries
@@ -69,9 +73,9 @@
   For example:
 <blockquote><pre>
 <b>test.cc:</b> In function <b>'int test(int, int, foo, int, int)'</b>:
-<b>test.cc:5:16:</b> <b style='color:red'>error:</b> no match for <b>'operator*'</b> (operand types are <b>'int'</b> and <b>'foo'</b>)
-   return p + <b style='color:red'>q * r</b> * s + t;
-              <b style='color:red'>~~^~~</b>
+<b>test.cc:5:16:</b> <span class="boldred">error:</span> no match for <b>'operator*'</b> (operand types are <b>'int'</b> and <b>'foo'</b>)
+   return p + <span class="boldred">q * r</span> * s + t;
+              <span class="boldred">~~^~~</span>
 </pre></blockquote>
 In addition, there is now initial support for precise diagnostic locations
 within strings:
@@ -85,16 +89,16 @@
       <!-- this is currently the only example in the tree; various others are pending  -->
 <blockquote><pre>
 <b>fixits.c:</b> In function <b>'bad_deref'</b>:
-<b>fixits.c:11:13:</b> <b style='color:red'>error:</b> <b>'ptr'</b> is a pointer; did you mean to use <b>'->'</b>?
-   return ptr<b style='color:red'>.</b>x;
-             <b style='color:red'>^</b>
-             <b style='color:red'>-></b>
+<b>fixits.c:11:13:</b> <span class="boldred">error:</span> <b>'ptr'</b> is a pointer; did you mean to use <b>'->'</b>?
+   return ptr<span class="boldred">.</span>x;
+             <span class="boldred">^</span>
+             <span class="boldred">-&gt;</span>
 </pre></blockquote></li>
     <li>The C and C++ compilers now offer suggestions for misspelled field names:
 <blockquote><pre>
-<b>spellcheck-fields.cc:52:13:</b> <b style='color:red'>error:</b> <b>'struct s'</b> has no member named <b>'colour'</b>; did you mean <b>'color'</b>?
-   return ptr-&gt;<b style='color:red'>colour</b>;
-               <b style='color:red'>^~~~~~</b>
+<b>spellcheck-fields.cc:52:13:</b> <span class="boldred">error:</span> <b>'struct s'</b> has no member named <b>'colour'</b>; did you mean <b>'color'</b>?
+   return ptr-&gt;<span class="boldred">colour</span>;
+               <span class="boldred">^~~~~~</span>
 </pre></blockquote></li>
     <!-- also, pending patch to add fix-it hints to the above -->
     <li>New command-line options have been added for the C and C++ compilers:
@@ -135,9 +139,9 @@
     <li>The C and C++ compilers now emit saner error messages if
       merge-conflict markers are present in a source file.
 <blockquote><pre>
-<b>test.c:3:1:</b> <b style='color:red'>error:</b> version control conflict marker in file
- <b style='color:red'>&lt;&lt;&lt;&lt;&lt;&lt;&lt;</b> HEAD
- <b style='color:red'>^~~~~~~</b>
+<b>test.c:3:1:</b> <span class="boldred">error:</span> version control conflict marker in file
+ <span class="boldred">&lt;&lt;&lt;&lt;&lt;&lt;&lt;</span> HEAD
+ <span class="boldred">^~~~~~~</span>
 </pre></blockquote></li>
   </ul>
 
@@ -454,7 +458,7 @@
       provide suggestions for misspelled command line options.
 <blockquote><pre>
 $ gcc -static-libfortran test.f95
-gcc: <b style='color:red'>error:</b> unrecognized command line option <b>'-static-libfortran'</b>; did you mean <b>'-static-libgfortran'</b>?
+gcc: <span class="boldred">error:</span> unrecognized command line option <b>'-static-libfortran'</b>; did you mean <b>'-static-libgfortran'</b>?
 </pre></blockquote></li>
     <li>The <code>--enable-default-pie</code> configure option enables
 	generation of PIE by default.</li>

Re: [wwwdocs] gcc-6/changes.html: diagnostics, Levenshtein, -Wmisleading-indentation, jit (v2)

[Jakub Jelinek]

On Tue, Jan 19, 2016 at 11:49:27PM +0100, Gerald Pfeifer wrote:
> On Tue, 19 Jan 2016, Jakub Jelinek wrote:
> > Perhaps we need to use something other than <b style='color:magenta'>...</b>
> > and similar, the question is what.  It certainly worked well back almost 3
> > years ago when I've added those into gcc-4.9/changes.html.
> 
> And interestingly it still does when I download the page and view
> it locally (Firefox 43 or Google Chrome).
> 
> Instead of hardcoding <b style='color:red'>text</b> it makes sense
> to use <span class="boldred">text</span> which is easier (and easier
> to tweak, and I just applied the patch below.

Note, we want to tweak gcc-{4.9,5}/changes.html too, and there are more
colors than just red in there.
Also, seems the colors disappeared also from e.g.
https://gcc.gnu.org/projects/cxx1z.html
which has
  <style type="text/css">
      /* <![CDATA[*/
        tr.separator { background: #ffffcc}
        .supported { color: green }
        .unsupported { color: red }
      /* ]]> */
    </style>

	Jakub

Re: [wwwdocs] gcc-6/changes.html: diagnostics, Levenshtein, -Wmisleading-indentation, jit (v2)

[Gerald Pfeifer]

On Tue, 19 Jan 2016, Jakub Jelinek wrote:
> Note, we want to tweak gcc-{4.9,5}/changes.html too, and 
> there are more colors than just red in there.

Yes, I just got tired and need to log off now.

> Also, seems the colors disappeared also from e.g.
> https://gcc.gnu.org/projects/cxx1z.html

Lovely.

It seems gcc.gnu.org enforces a strict Content Security Policy
(cf. http://www.html5rocks.com/en/tutorials/security/content-security-policy/
for example) which does not allow for inline CSS styles.

  Content-Security-Policy: default-src 'self' http: https:

So either we get the configuration of the web server changed, or
indeed we need to touch all those existing pages.

Gerald

Re: [wwwdocs] gcc-6/changes.html: diagnostics, Levenshtein, -Wmisleading-indentation, jit (v2)

[Jakub Jelinek]

On Wed, Jan 20, 2016 at 12:17:36AM +0100, Gerald Pfeifer wrote:
> On Tue, 19 Jan 2016, Jakub Jelinek wrote:
> > Note, we want to tweak gcc-{4.9,5}/changes.html too, and 
> > there are more colors than just red in there.
> 
> Yes, I just got tired and need to log off now.
> 
> > Also, seems the colors disappeared also from e.g.
> > https://gcc.gnu.org/projects/cxx1z.html
> 
> Lovely.
> 
> It seems gcc.gnu.org enforces a strict Content Security Policy
> (cf. http://www.html5rocks.com/en/tutorials/security/content-security-policy/
> for example) which does not allow for inline CSS styles.
> 
>   Content-Security-Policy: default-src 'self' http: https:
> 
> So either we get the configuration of the web server changed, or
> indeed we need to touch all those existing pages.

At least the warning/error/note styles are something that multiple pages are
using and going to use in the future, so if that could be defined in the
main gcc.css, it would be enough.

	Jakub

Re: [wwwdocs] gcc-6/changes.html: diagnostics, Levenshtein, -Wmisleading-indentation, jit (v2)

[Jakub Jelinek]

On Wed, Jan 20, 2016 at 12:40:08AM +0100, Jakub Jelinek wrote:
> On Wed, Jan 20, 2016 at 12:17:36AM +0100, Gerald Pfeifer wrote:
> > On Tue, 19 Jan 2016, Jakub Jelinek wrote:
> > > Note, we want to tweak gcc-{4.9,5}/changes.html too, and 
> > > there are more colors than just red in there.
> > 
> > Yes, I just got tired and need to log off now.
> > 
> > > Also, seems the colors disappeared also from e.g.
> > > https://gcc.gnu.org/projects/cxx1z.html
> > 
> > Lovely.
> > 
> > It seems gcc.gnu.org enforces a strict Content Security Policy
> > (cf. http://www.html5rocks.com/en/tutorials/security/content-security-policy/
> > for example) which does not allow for inline CSS styles.
> > 
> >   Content-Security-Policy: default-src 'self' http: https:

BTW, is that also the reason why very recently the gcc.gnu.org homepage
changed layout (the News column is much wider than the Release Series and Status
column), at least with Firefox 43.0?  The page has:
<td style="width: 50%; padding-right: 8px;" valign="top">
etc.

	Jakub

Re: [wwwdocs] gcc-6/changes.html: diagnostics, Levenshtein, -Wmisleading-indentation, jit (v2)

[Gerald Pfeifer]

On Wed, 20 Jan 2016, Jakub Jelinek wrote:
>>   Content-Security-Policy: default-src 'self' http: https:
>> 
>> So either we get the configuration of the web server changed, or
>> indeed we need to touch all those existing pages.
> At least the warning/error/note styles are something that multiple pages 
> are using and going to use in the future, so if that could be defined in 
> the main gcc.css, it would be enough.

Done thusly.  With this change, at least gcc-6/changes.html should
be fine again.

And I can commit working my way backwards through all the other
changes.html pages over the coming couple of days.

Gerald


Move the boldred class from gcc-6/changes.html to gcc.css.
Introduce boldcyan and boldmagenta classes and use them in
gcc-6/changes.html.

Index: gcc.css
===================================================================
RCS file: /cvs/gcc/wwwdocs/htdocs/gcc.css,v
retrieving revision 1.25
diff -u -r1.25 gcc.css
--- gcc.css	12 Sep 2011 09:42:59 -0000	1.25
+++ gcc.css	20 Jan 2016 17:26:10 -0000
@@ -49,7 +49,11 @@
   border-width: thin;
   padding: 4px;
 }
-                  
+
+.boldcyan    { font-weight:bold; color:cyan; }
+.boldmagenta { font-weight:bold; color:magenta; }
+.boldred     { font-weight:bold; color:red; }
+
 /* Classpath versus libgcj merge status page. */
 
 .classpath-only         { background-color: #FFFFAA; }
Index: gcc-6/changes.html
===================================================================
RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-6/changes.html,v
retrieving revision 1.49
diff -u -r1.49 changes.html
--- gcc-6/changes.html	19 Jan 2016 22:42:16 -0000	1.49
+++ gcc-6/changes.html	20 Jan 2016 17:26:10 -0000
@@ -3,11 +3,6 @@
 <head>
 <title>GCC 6 Release Series &mdash; Changes, New Features, and Fixes</title>
 
-<style type="text/css">
-  .boldred { font-weight:bold; color:red; }
-</style>
-
 <!-- GCC maintainers, please do not hesitate to update/contribute entries
      concerning those part of GCC you maintain!  2002-03-23, Gerald.
 -->
@@ -80,9 +75,9 @@
 In addition, there is now initial support for precise diagnostic locations
 within strings:
 <blockquote><pre>
-<b>format-strings.c:3:14:</b> <b style='color:magenta'>warning:</b> field width specifier <b>'*'</b> expects a matching <b>'int'</b> argument [<b style='color:magenta'>-Wformat=</b>]
+<b>format-strings.c:3:14:</b> <span class="boldmagenta">warning:</span> field width specifier <b>'*'</b> expects a matching <b>'int'</b> argument [<span class="boldmagenta">-Wformat=</span>]
    printf("%*d");
-            <b style='color:magenta'>^</b>
+            <span class="boldmagenta">^</span>
 </pre></blockquote></li>
     <li>Diagnostics can now contain "fix-it hints", which are displayed
       in context underneath the relevant source code.  For example:
@@ -126,12 +121,12 @@
           <a href="https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2014-1266">CVE-2014-1266</a>:
 <blockquote><pre>
 <b>sslKeyExchange.c:</b> In function <b>'SSLVerifySignedServerKeyExchange'</b>:
-<b>sslKeyExchange.c:631:8:</b> <b style='color:magenta'>warning:</b> statement is indented as if it were guarded by... [<b style='color:magenta'>-Wmisleading-indentation</b>]
-        <b style='color:magenta'>goto</b> fail;
-        <b style='color:magenta'>^~~~</b>
-<b>sslKeyExchange.c:629:4:</b> <b style='color:cyan'>note:</b> ...this 'if' clause, but it is not
-    <b style='color:cyan'>if</b> ((err = SSLHashSHA1.update(&amp;hashCtx, &amp;signedParams)) != 0)
-    <b style='color:cyan'>^~</b>
+<b>sslKeyExchange.c:631:8:</b> <span class="boldmagenta">warning:</span> statement is indented as if it were guarded by... [<span class="boldmagenta">-Wmisleading-indentation</span>]
+        <span class="boldmagenta">goto</span> fail;
+        <span class="boldmagenta">^~~~</span>
+<b>sslKeyExchange.c:629:4:</b> <span class="boldcyan">note:</span> ...this 'if' clause, but it is not
+    <span class="boldcyan">if</span> ((err = SSLHashSHA1.update(&amp;hashCtx, &amp;signedParams)) != 0)
+    <span class="boldcyan">^~</span>
 </pre></blockquote>
           This warning is enabled by <code>-Wall</code>.</li>
       </ul>

Re: [wwwdocs] gcc-6/changes.html: diagnostics, Levenshtein, -Wmisleading-indentation, jit (v2)

[Manuel López-Ibáñez]

On 20 January 2016 at 17:38, Gerald Pfeifer <gerald@pfeifer.com> wrote:
> On Wed, 20 Jan 2016, Jakub Jelinek wrote:
>>>   Content-Security-Policy: default-src 'self' http: https:
>>>
>>> So either we get the configuration of the web server changed, or
>>> indeed we need to touch all those existing pages.
>> At least the warning/error/note styles are something that multiple pages
>> are using and going to use in the future, so if that could be defined in
>> the main gcc.css, it would be enough.
>
> Done thusly.  With this change, at least gcc-6/changes.html should
> be fine again.
>
> And I can commit working my way backwards through all the other
> changes.html pages over the coming couple of days.

wwwdocs/htdocs$ find . -name '*.html' | xargs grep --color -e " style *="

shows a bit more inline CSS than changes.html, unfortunately.

Re: [wwwdocs] gcc-6/changes.html: diagnostics, Levenshtein, -Wmisleading-indentation, jit (v2)

[Gerald Pfeifer]

[-- Attachment #1: Type: text/plain, Size: 476 bytes --]

On Wed, 20 Jan 2016, Manuel López-Ibáñez wrote:
>> And I can commit working my way backwards through all the other
>> changes.html pages over the coming couple of days.
> wwwdocs/htdocs$ find . -name '*.html' | xargs grep --color -e " style *="
> 
> shows a bit more inline CSS than changes.html, unfortunately.

Yes, I know.  I'll also take care of the others (may just take
some days for the release-specific ones, possibly a tad longer
for the few others).

Gerald

Re: [wwwdocs] gcc-6/changes.html: diagnostics, Levenshtein, -Wmisleading-indentation, jit (v2)

[Markus Trippelsdorf]

On 2016.01.20 at 18:38 +0100, Gerald Pfeifer wrote:
> On Wed, 20 Jan 2016, Jakub Jelinek wrote:
> >>   Content-Security-Policy: default-src 'self' http: https:
> >> 
> >> So either we get the configuration of the web server changed, or
> >> indeed we need to touch all those existing pages.
> > At least the warning/error/note styles are something that multiple pages 
> > are using and going to use in the future, so if that could be defined in 
> > the main gcc.css, it would be enough.
> 
> Done thusly.  With this change, at least gcc-6/changes.html should
> be fine again.
> 
> And I can commit working my way backwards through all the other
> changes.html pages over the coming couple of days.
> 
> Gerald
> 
> 
> Move the boldred class from gcc-6/changes.html to gcc.css.
> Introduce boldcyan and boldmagenta classes and use them in
> gcc-6/changes.html.
> 
> Index: gcc.css
> ===================================================================
> RCS file: /cvs/gcc/wwwdocs/htdocs/gcc.css,v
> retrieving revision 1.25
> diff -u -r1.25 gcc.css
> --- gcc.css	12 Sep 2011 09:42:59 -0000	1.25
> +++ gcc.css	20 Jan 2016 17:26:10 -0000
> @@ -49,7 +49,11 @@
>    border-width: thin;
>    padding: 4px;
>  }
> -                  
> +
> +.boldcyan    { font-weight:bold; color:cyan; }

This color is unreadable on white background. See the notes for
-Wmisleading-indentation on http://gcc.gnu.org/gcc-6/changes.html

Also the gcc homepage looks weird. The news column is much too wide and
the "Release Series and Status" to small.

-- 
Markus

Re: [wwwdocs] gcc-6/changes.html: diagnostics, Levenshtein, -Wmisleading-indentation, jit (v2)

[Jakub Jelinek]

On Thu, Jan 28, 2016 at 02:19:09PM +0100, Markus Trippelsdorf wrote:
> > Move the boldred class from gcc-6/changes.html to gcc.css.
> > Introduce boldcyan and boldmagenta classes and use them in
> > gcc-6/changes.html.
> > 
> > Index: gcc.css
> > ===================================================================
> > RCS file: /cvs/gcc/wwwdocs/htdocs/gcc.css,v
> > retrieving revision 1.25
> > diff -u -r1.25 gcc.css
> > --- gcc.css	12 Sep 2011 09:42:59 -0000	1.25
> > +++ gcc.css	20 Jan 2016 17:26:10 -0000
> > @@ -49,7 +49,11 @@
> >    border-width: thin;
> >    padding: 4px;
> >  }
> > -                  
> > +
> > +.boldcyan    { font-weight:bold; color:cyan; }
> 
> This color is unreadable on white background. See the notes for
> -Wmisleading-indentation on http://gcc.gnu.org/gcc-6/changes.html

It is not so unreadable, and +/- matches the actual color used by gcc,
doesn't it?

> Also the gcc homepage looks weird. The news column is much too wide and
> the "Release Series and Status" to small.

Yeah, the home page needs changes, not sure if we want a separate *.css file
for it because it has lots of different inline styles and tweaks that need
replacement in *.css with the strict setting.

	Jakub

gcc.gnu.org and Content-Security-Policy (was: gcc-6/changes.html: diagnostics, Levenshtein, -Wmisleading-indentation, jit (v2))

[Gerald Pfeifer]

On Wed, 20 Jan 2016, Jakub Jelinek wrote:
>>> It seems gcc.gnu.org enforces a strict Content Security Policy
>>> (cf. http://www.html5rocks.com/en/tutorials/security/content-security-policy/
>>> for example) which does not allow for inline CSS styles.
>>> 
>>>   Content-Security-Policy: default-src 'self' http: https:
> BTW, is that also the reason why very recently the gcc.gnu.org homepage
> changed layout (the News column is much wider than the Release Series and Status
> column), at least with Firefox 43.0?  The page has:
> <td style="width: 50%; padding-right: 8px;" valign="top">

Yes, exactly!

I had addressed most of that back then last year, and now finally
completed the last missing pieces.

(There are only two bits of local "style=" left on our web site, 
in projects/gupc.html.)

Gerald