public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: vogt@linux.vnet.ibm.com, gcc-patches@gcc.gnu.org,
	       Andreas Krebbel <krebbel@linux.vnet.ibm.com>,
	       Jonathan Wakely <jwakely@redhat.com>
Subject: Re: [PATCH] PR c++/69462: Provide FLT_EVAL_METHOD and DECIMAL_DIG in float.h.
Date: Fri, 29 Jan 2016 08:32:00 -0000	[thread overview]
Message-ID: <20160129083244.GJ3017@tucnak.redhat.com> (raw)
In-Reply-To: <20160129082746.GA3844@linux.vnet.ibm.com>

On Fri, Jan 29, 2016 at 09:27:46AM +0100, Dominik Vogt wrote:
> On Thu, Jan 28, 2016 at 03:41:29PM +0100, Jakub Jelinek wrote:
> > On Thu, Jan 28, 2016 at 01:40:12PM +0100, Dominik Vogt wrote:
> > > -#if defined (__STDC_VERSION__) && __STDC_VERSION__ >= 199901L
> > > +#if (defined (__STDC_VERSION__) && __STDC_VERSION__ >= 199901L) \
> > > +	|| (defined (__cplusplus) && __cplusplus >= 201103L)
> > 
> > The formatting is wrong, there is a tab before || when it should be aligned
> > below defined on the previous line.
> 
> Attached.

> gcc/ChangeLog
> 
> 	PR c++/69462
> 	* ginclude/float.h: Also provide FLT_EVAL_METHOD and DECIMAL_DIG for
> 	C++-11.

Ok, thanks.

> --- a/gcc/ginclude/float.h
> +++ b/gcc/ginclude/float.h
> @@ -127,7 +127,8 @@ see the files COPYING3 and COPYING.RUNTIME respectively.  If not, see
>  #undef FLT_ROUNDS
>  #define FLT_ROUNDS 1
>  
> -#if defined (__STDC_VERSION__) && __STDC_VERSION__ >= 199901L
> +#if (defined (__STDC_VERSION__) && __STDC_VERSION__ >= 199901L) \
> +     || (defined (__cplusplus) && __cplusplus >= 201103L)
>  /* The floating-point expression evaluation method.
>          -1  indeterminate
>           0  evaluate all operations and constants just to the range and

	Jakub

  reply	other threads:[~2016-01-29  8:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-28 12:40 Dominik Vogt
2016-01-28 13:32 ` Jonathan Wakely
2016-01-28 14:42   ` Jakub Jelinek
2016-01-29 12:29     ` Jonathan Wakely
2016-01-28 14:41 ` Jakub Jelinek
2016-01-29  8:27   ` Dominik Vogt
2016-01-29  8:32     ` Jakub Jelinek [this message]
2016-01-29 10:06     ` Andreas Krebbel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160129083244.GJ3017@tucnak.redhat.com \
    --to=jakub@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jwakely@redhat.com \
    --cc=krebbel@linux.vnet.ibm.com \
    --cc=vogt@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).